trim "six" usage #112
Merged
trim "six" usage #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardscholtens
approved these changes
Jun 6, 2025
|
Yes indeed. SQLAlchemy itself dropped python2 support before |
|
@mwatts15 , what do you think? I think it can be merged. |
|
I haven't reviewed, but I've no problem with removing Python 2 support.
I'll merge as soon as I can.
…On Sat, Jun 7, 2025, 06:22 Richard Scholtens ***@***.***> wrote:
*richardscholtens* left a comment (RDFLib/rdflib-sqlalchemy#112)
<#112 (comment)>
@mwatts15 <https://github.com/mwatts15> , what do you think? I think it
can be merged.
—
Reply to this email directly, view it on GitHub
<#112 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALLFSENVPCS6UVJE73DMXD3CLDONAVCNFSM6AAAAABZD3ZXFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNJSGM3TCOJUGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@mwatts15 thanks for the quick response! If you have time when merging this PR could you also check if it is possible to merge the development branch into master and make that the default? Currently when installing with pip the master branch gets installed. I would really appreciate it! Also see: |
mwatts15
approved these changes
Jun 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.