Merge Game Origin Rewrite branch and master #42
Conversation
Try to fix an issue when song_id is specified in missing song data
allows 2x bass pedal versions of songs to exist in one MIDI. plus there is a new modifier to toggle this
Forgot that I need to actually call the original function, lol
Fixes the RB3 (bug?) where 2 red leds stay on after exiting the score screen. This fix turns them off.
SK Led fix on score overview exit
config.GoCentralAddress is defined in the ini spec in config.h as being of up to RB3E_MAX_DOMAIN chars, but the strncpy routine for that item was only copying RB3E_MAX_CONFIG_LEN; this was 30 chars. The announced Xbox URI had precisely 31 characters. This caused all DNS lookups for this address to fail, and no connection to be made to the GoCentral server.
Extend strncpy(config.GoCentralAddress) to full field length
adding the original version created by emma for tracking purposes before committing changes
add index created by @InvoxiPlayGames
This updates the styling of the page to be a bit more modern. The page also has a theme per the running device state of light mode vs dark mode. Add's the ability to use (or hide) a lastfm api key for album art fetching. This isnt a perfect mechanism so you are also able to hide the api key field to not attempt getting album images. The album images are tagged and cached based on the corresponding song tag, so any arbitrary filtering of the song list will continue to match the cached image. filtered searches trigger faster api calls so the user isnt sat looking at a blank image. once search is unfiltered, the task for populating art for the entire library continues running. No longer need to click a search button to trigger a search, can live type and live filter.
massively overhaul rb3e_index.html
…y toolchain update
Support for scripts over the network
|
Also, I have a mock up PR on my fork where you can see the diff of this potential PR against master, for a more accurate assessment of the actual code being changed around |
I put the wrong version of songhooks.c
correct some issues i noticed
|
I did a full sanity check looking over my mock PR files changed tab, and noticed i made a couple small errors, im otherwise feeling good about it. |
[Wii] Load encrypted SD DLC as if they were on NAND
|
added latest pushes from upstream |
Add bank8 addresses, fix bank8 compile
|
I just added bank8 addresses (i am so sorry i meant to squash and merge.....) I did not figure out the vector port addresses, inlining meme, but i also noticed they go unused anywhere within rb3e, only defined
|
|
I got the milo highlight issue figured out for the xbox milo, unfortunately I am having issues with the wii milo The fix for xbox was just to reorder the mesh in the primary.grp to the top, but it appears some differences in the wii mesh (different geom_owner and mat) make this a bit different. When I tried to duplicate the same mesh, the location of the icon moved to the right hand side. Might need a bit more attention from comp on the specific wii differences as I am not as versed in 010 to dig deeper list_song_select_browser.milo_xbox.zip
|
|
|
This PR merges all upstream into game origin rewrite. I spent a great deal of time doing my best to keep the newer data labeling in-tact where applicable. I did my best but keep in mind I am only just learning. It would be wise to make sure and give this a nice look over to ensure accuracy. I did spend my time on this, I did not just throw this in chatgpt.
(sorry for commit spam)
What is not done:
Relevant Wii Bank 8 port addresses, I only merged what existed, i did not fetch those.
everything else comp mentioned, this only merges upstream.
Tested:
Builds Wii via github actions, builds Xbox locally
Tested locally on Xbox 360 hardware, everything seems correct
new icon rewrite works, double bass pedal modifier works, dtafunctions work, gocentral works, song id correction works, everything appears in order.
Not Tested:
Actually running on wii (my workflow is very heavily focused on bank8)