Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible MP URL #98

Merged
merged 1 commit into from
Oct 3, 2023
Merged

More flexible MP URL #98

merged 1 commit into from
Oct 3, 2023

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Oct 2, 2023

This PR allows MP to be deployed in a different place than inside the cluster. Also unifies MP configuration between charts.

Backwards incompatible chance: MP URL setting name changed to managementportal_url from managementportalHost or managementportal_host in following charts:

  • app-config
  • radar-appserver
  • radar-fitbit-connector
  • radar-gateway
  • radar-home
  • radar-integration
  • radar-rest-sources-backend
  • radar-upload-connect-backend
  • radar-upload-source-connector

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

@blootsvoets
Copy link
Contributor

Seems fine to unify this config. Please rename managementportal_host to managementportal_url to clarify the contents of the variable.

@keyvaann
Copy link
Collaborator Author

keyvaann commented Oct 2, 2023

managementportal_url makes more sense but it will cause more back incompatibility which I tried to avoid.

@blootsvoets
Copy link
Contributor

Then perhaps making it something new, managementportal: url: …?

@keyvaann
Copy link
Collaborator Author

keyvaann commented Oct 3, 2023

Updated the variable

Copy link
Contributor

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyvaann keyvaann merged commit 0881c3c into main Oct 3, 2023
4 checks passed
@keyvaann keyvaann deleted the mp-url branch October 3, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants