Skip to content

Conversation

keyvaann
Copy link
Collaborator

@keyvaann keyvaann commented Feb 3, 2025

JMX exporter image didn't had the ability to configure image registry, this PR adds that feature.

@keyvaann keyvaann requested a review from pvannierop February 3, 2025 09:43
Copy link

github-actions bot commented Feb 3, 2025

Great PR! Please pay attention to the following items before merging:

Files matching charts/*/values.yaml:

  • Is the PR adding a new container? Please reviewer, add it to the models (internal process)
  • Is the PR adding a new parameter? Please, ensure it’s documented in the README.md

This is an automatically generated QA checklist based on modified files.

Copy link
Contributor

@pvannierop pvannierop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keyvaann keyvaann merged commit 212b99f into main Feb 3, 2025
5 checks passed
@keyvaann keyvaann deleted the radar-gateway-add-image-registry branch February 3, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants