Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress-nginx chart to appversion 1.10.1 #126

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

Bdegraaf1234
Copy link
Collaborator

Description of the change*

Update the ingress-nginx chart to appversion 1.10.1

Benefits

Security updates fixing at least one CVE

Possible drawbacks

None

Applicable issues

NA

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [<name_of_the_chart>])

@Bdegraaf1234 Bdegraaf1234 requested a review from keyvaann April 30, 2024 16:22
@Bdegraaf1234 Bdegraaf1234 self-assigned this Apr 30, 2024
@Bdegraaf1234
Copy link
Collaborator Author

@keyvaann let me know if you want to remove all the changelogs and perhaps also the CI and test folders?

@keyvaann
Copy link
Collaborator

keyvaann commented May 1, 2024

Yes thanks, let's remove the those new directories. Also please keep the commands that you have used so we can add it to #65 later and make thing more automated.

@Bdegraaf1234
Copy link
Collaborator Author

this was done using the exact commands from that makefile, and removing the changelogs was:

rm -rf external/ingress-nginx/changelog/ external/ingress-nginx/ci/ external/ingress-nginx/tests/

@Bdegraaf1234 Bdegraaf1234 force-pushed the update-ingress-nginx branch from 9f9e870 to d9f350d Compare May 1, 2024 11:54
@keyvaann
Copy link
Collaborator

keyvaann commented May 1, 2024

Great. Do you know why radar-backend and kafka-manager are also involved in the new commits?

@Bdegraaf1234 Bdegraaf1234 force-pushed the update-ingress-nginx branch from d9f350d to f7a7236 Compare May 1, 2024 12:21
@Bdegraaf1234
Copy link
Collaborator Author

Thats was a mistake, when I run helmdocs a bunch of files get 'changed'

Copy link
Collaborator

@keyvaann keyvaann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Bdegraaf1234 Bdegraaf1234 merged commit 8c697c2 into main May 1, 2024
1 check passed
@Bdegraaf1234 Bdegraaf1234 deleted the update-ingress-nginx branch May 1, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants