Skip to content

Add support to spaCy v3 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 16, 2021
Merged

Add support to spaCy v3 #52

merged 7 commits into from
Feb 16, 2021

Conversation

R1j1t
Copy link
Owner

@R1j1t R1j1t commented Feb 12, 2021 •
edited
Loading

Description

Checklist

  • Added and/or updated the test (not required for documentation changes)
  • My changes don't require a change to the documentation, or if they do, I've added all required information

@jonmun @R1j1t
Update to spacyv3 (#49)
8c574ef 
* Resolved #48 by migrating the code to match the nlp pipeline in spacy v3. See: https://nightly.spacy.io/usage/v3#migrating-add-pipe

* updated tests in contextualSpellCheck.py to match the pipeline in spacy v3

* updated spacy dependency number

* black lint

* Update tests

Co-authored-by: R1j1t <22280243+R1j1t@users.noreply.github.com>
@R1j1t R1j1t changed the title Update to spacyv3 (#49) Add support to spaCy v3 Feb 12, 2021
@R1j1t R1j1t added the enhancement New feature or request label Feb 12, 2021
@R1j1t R1j1t linked an issue Feb 16, 2021 that may be closed by this pull request
[BUG] compatibility issue with spacy v3 #48
Closed
@R1j1t R1j1t added the documentation Improvements or additions to documentation label Feb 16, 2021
@R1j1t R1j1t merged commit 5b65bad into master Feb 16, 2021
@R1j1t R1j1t deleted the feature/spaCyv3Support branch February 16, 2021 17:14
@R1j1t R1j1t linked an issue Feb 17, 2021 that may be closed by this pull request
dependency version number in setup.py #38
Closed
R1j1t added a commit that referenced this pull request Aug 22, 2021
@R1j1t
update doc task list, completed by #52
de933ef
R1j1t added a commit that referenced this pull request Aug 22, 2021
@R1j1t
Removed optional dependency from requirements.txt (#65)
033f203 
* fixes #47

* update doc task list, completed by #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] compatibility issue with spacy v3 dependency version number in setup.py
2 participants
@R1j1t @jonmun