Skip to content

Conversation

@R0Wi
Copy link
Contributor

@R0Wi R0Wi commented Oct 8, 2020

No description provided.

@R0Wi R0Wi added the enhancement New feature or request label Oct 8, 2020
@R0Wi R0Wi requested a review from bahnwaerter October 8, 2020 06:13
@R0Wi R0Wi linked an issue Oct 8, 2020 that may be closed by this pull request
10 tasks
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #28 into master will increase coverage by 5.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
+ Coverage     72.53%   77.57%   +5.04%     
- Complexity      105      111       +6     
============================================
  Files            15       16       +1     
  Lines           324      330       +6     
============================================
+ Hits            235      256      +21     
+ Misses           89       74      -15     
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 100.00% <100.00%> (+14.28%) 6.00 <6.00> (+3.00)
lib/BackgroundJobs/ProcessFileJob.php 100.00% <100.00%> (ø) 19.00 <0.00> (ø)
lib/Listener/RegisterFlowOperationsListener.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
lib/OcrProcessors/OcrProcessorFactory.php 100.00% <100.00%> (ø) 3.00 <1.00> (ø)
lib/Operation.php 100.00% <100.00%> (+27.27%) 18.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2542f...c02f4f5. Read the comment docs.

@R0Wi R0Wi marked this pull request as ready for review October 9, 2020 05:34
@R0Wi
Copy link
Contributor Author

R0Wi commented Oct 9, 2020

@bahnwaerter this is ready now. Please check the list at #26 for testing / review purposes.

Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the app with theses changes on a fresh installed NC 20.0.0 instance. The OCR processing with the app works without any issues such that the compatibility for NC 20 is preserved.

@bahnwaerter bahnwaerter merged commit 796222c into master Oct 10, 2020
@bahnwaerter bahnwaerter deleted the feature/NC20#26 branch October 10, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nextcloud 20 compatibility

3 participants