Skip to content

perf: computed signals only trigger when changed #8148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmertens merged 2 commits into from
Nov 12, 2025
Merged

perf: computed signals only trigger when changed #8148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba4d5bd
fix(preload): set anonymous on bundlegraph preload
wmertens Nov 6, 2025
767c981
perf: computed signals only trigger when changed
wmertens Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/loud-cars-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/qwik': minor
---

PERF: Computed signals now only trigger listeners if their value has changed
6 changes: 4 additions & 2 deletions packages/qwik/src/core/use/use-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,8 +750,10 @@ export const runComputed = (
untrack(() => {
const signal = task.$state$! as SignalInternal<unknown>;
signal[QObjectSignalFlags] &= ~SIGNAL_UNASSIGNED;
signal.untrackedValue = returnValue;
signal[QObjectManagerSymbol].$notifySubs$();
if (signal.untrackedValue !== returnValue) {
signal.untrackedValue = returnValue;
signal[QObjectManagerSymbol].$notifySubs$();
}
});
};
const fail = (reason: unknown) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/qwik/src/server/preload-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export const preloaderPre = (
* We add modulepreloads even when the script is at the top because they already fire during
* html download
*/
jsx('link', { rel: 'modulepreload', href: preloaderPath, nonce }),
jsx('link', { rel: 'modulepreload', href: preloaderPath, nonce, crossorigin: 'anonymous' }),
jsx('link', {
rel: 'preload',
href: bundleGraphPath,
Expand Down