fix: over-preloading due to inaccurate bundle-graph static import graph #7982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76e7f0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maiieul
force-pushed
the
fix-manualChunks-merging
branch
from
aa4e8f4 to
3a82933
Compare
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
maiieul
force-pushed
the
fix-manualChunks-merging
branch
from
3a82933 to
a8a7494
Compare
maiieul
force-pushed
the
fix-manualChunks-merging
branch
from
a8a7494 to
1ef8eb2
Compare
gioboa
previously approved these changes
Sep 22, 2025
wmertens
requested changes
Sep 22, 2025
maiieul
force-pushed
the
fix-manualChunks-merging
branch
from
618adcf to
854d753
Compare
github-project-automation
bot
moved this from Waiting For Review
to Done
in Qwik Development
gioboa
reviewed
Sep 24, 2025
| outputOpts.onlyExplicitManualChunks = true; | ||
| } else { | ||
| console.warn( | ||
| `⚠️ We detected that you're using a Rollup version prior to 4.52.0 (${version}). For the latest and greatest, we recommend to let Vite install the latest version for you, or manually install the latest version of Rollup in your project if that doesn't work. It will enable the new Rollup \`outputOpts.onlyExplicitManualChunks\` feature flag, which improves preloading performance and reduces cache invalidation for a snappier user experience.` |
Member
There was a problem hiding this comment.
Nice one 👏 we can add a link to their official doc 💡
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Fixes #7882
Installs Rollup 4.52 and marks it as a peer dep. Warns the developers that they should update to get the new
output.onlyExplicitManualChunksfeature working on their project.The first bundle won't get non specified dependencies merged into its manualChunk anymore. This reduces over-preloading for that bundle and cache invalidation.
See rollup/rollup#6087 for more info on
onlyExplicitManualChunks.We can remove this code when we'll update qwik to Rollup 5.
Checklist
pnpm change