Skip to content

Conversation

@maiieul
Copy link
Member

@maiieul maiieul commented Sep 3, 2025

What is it?

  • Feature / enhancement

Description

This should remove a few unecessary empty imports added by rollup and then not tree-shaken like import "./preloader.js".

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner September 3, 2025 15:55
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: 7bfb4b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge September 3, 2025 16:10
@wmertens wmertens merged commit 4f128c9 into QwikDev:main Sep 3, 2025
18 checks passed
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏💪

@maiieul maiieul self-assigned this Sep 4, 2025
@maiieul maiieul moved this from Backlog to Done in Qwik Development Sep 4, 2025
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants