Skip to content

Conversation

@gioboa
Copy link
Member

@gioboa gioboa commented Aug 23, 2025

Close #7854

Otherwise there might be some side effects imports when building a consumer project, which will be added as static imports to the bundle graph, leading to slight over-prefetching of unnecessary bundles for user events.

@gioboa gioboa requested a review from a team as a code owner August 23, 2025 12:01
@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2025

🦋 Changeset detected

Latest commit: 71ea2dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
create-qwik Patch
@builder.io/qwik Patch
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 71ea2dd

@wmertens
Copy link
Member

Yes great, but the README should include a paraghraph saying that the side-effects are set to false, and that if there are side effects (like a global being set), then it should be removed, possibly only for the file that has it.

That field isn't a part of the npm spec, but it is used by bundlers, and the best documentation is at https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

@gioboa gioboa requested a review from a team as a code owner August 24, 2025 14:49
@gioboa
Copy link
Member Author

gioboa commented Aug 24, 2025

Yes great, but the README should include a paraghraph saying that the side-effects are set to false...

Added

@gioboa gioboa requested a review from wmertens August 24, 2025 14:52
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7855
npm i https://pkg.pr.new/@builder.io/qwik-city@7855
npm i https://pkg.pr.new/eslint-plugin-qwik@7855
npm i https://pkg.pr.new/create-qwik@7855

commit: 71ea2dd

Copy link
Member Author

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That e2e test is flaky, let me run it again

@gioboa gioboa enabled auto-merge (squash) August 25, 2025 11:39
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gioboa gioboa disabled auto-merge August 25, 2025 12:05
@gioboa gioboa merged commit 89b5f3a into QwikDev:main Aug 25, 2025
51 of 55 checks passed
@gioboa gioboa deleted the chore/change-lib-config branch August 25, 2025 12:38
@github-actions github-actions bot mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

library starters package.json should include "sideEffects": false field

2 participants