fix: invalidate module in createQwikPlugin slows down cypress component tests

[maiieul]

What is it?

• Bug

Description

invalidateModule is used for HMR in Vite handleHotUpdate hook. It was added in a69de93 in an attempt to make sure that QRLs also get updated on parent changes.

The problem is that this causes cypress component tests (CCTs) to be 10x slower, eventually leading to CCTs startup timing out with a "Error: Code(5): You can render over a existing q:container. Skipping render()." message.

I tried many possible combinations of updating the child, the parent, the jsx, the useVisibleTask, the useTask, the QRL outside of the component... I haven't been able to trigger a case where the invalidateModule in the transform hook with the optimizer would ever run.

What seems to happen is that the handleHotUpdate hook will invalidate the module, which will then trigger the transform hook for the corresponding module and its QRLs.

Here's an example log:

invalidating module HMR /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
invalidating module HMR /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
invalidating module HMR /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
invalidating module HMR /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_div_button_onClick_fDhgqdXxNQQ.js
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_yQ6Hre9qSVo.js
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_useVisibleTask_ISI2k8PkKII.js
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_computedCount_useComputed_OKKHalBLW9E.js
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_computedCount_useComputed_OKKHalBLW9E.js
transform /Users/maieul/dev/playgrounds/qwik-express/src/components/counter2.tsx_Counter2_component_useVisibleTask_ISI2k8PkKII.js

Conclusion: We should remove the invalidateModule in the transform hook because it impacts CCTs and it seems to never run. Even if it runs rare occasions, it's more important to enable CCTs to work rather than HMR in rare circumstances.

If someone can give me a reproduction of when QRLs don't get updated on parent change, I can reassess and try to find a fix that works both for CCTs and HMR.

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6f45fe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7726

npm i https://pkg.pr.new/@builder.io/qwik-city@7726

npm i https://pkg.pr.new/eslint-plugin-qwik@7726

npm i https://pkg.pr.new/create-qwik@7726

commit: 6f45fe9

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	6f45fe9