Skip to content

fix(view-transition): rename qwik-router-spa to qwik-navigation #7713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: build/v2
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/angry-boats-lose.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@qwik.dev/router': patch
---

Bugfix - rename the view transition type in CSS to prevent default view transition on SPA navigation
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export default component$(() => {
});
```

When listening on the `qviewTransition` we know that
When listening on the `qviewtransition` we know that

> **Note**: For it to work correctly, we need to **remove the default view transition** animation else it happens on top of the `.animate()`. I'm using `view-transition-class` which is only working with Chrome right now.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export const QwikRouterProvider = component$<QwikRouterProps>((props) => {
useStyles$(`
@layer qwik {
@supports selector(html:active-view-transition-type(type)) {
html:active-view-transition-type(qwik-router-spa) {
html:active-view-transition-type(qwik-navigation) {
:root{view-transition-name:none}
}
}
Expand Down