Skip to content

fix(vercel) vercel.json source pattern #7663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmbartschat
Copy link
Contributor

@cmbartschat cmbartschat commented Jun 8, 2025

What is it?

  • Bug

Description

When deploying to vercel I saw an "Invalid route source pattern" error.

This pattern seems to have been modified in f0388d4#diff-c6a948ae10892b24f31a2545d6eb120f1a47f4f338221fa087eff4e7688e34b9R13 which dropped the parenthesis around the .*, which seem to be required. After this change I was able to deploy, and see the correct cache headers:

Screenshot showing response headers for a /build/ response from vercel, containing public, max-age=31536000, s-maxage=31536000, immutable

@cmbartschat cmbartschat requested a review from a team as a code owner June 8, 2025 03:35
Copy link

changeset-bot bot commented Jun 8, 2025

⚠️ No Changeset found

Latest commit: 857b0ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 8, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7663
npm i https://pkg.pr.new/@builder.io/qwik-city@7663
npm i https://pkg.pr.new/eslint-plugin-qwik@7663
npm i https://pkg.pr.new/create-qwik@7663

commit: 857b0ef

Copy link
Contributor

github-actions bot commented Jun 8, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 857b0ef

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @cmbartschat

@gioboa gioboa requested a review from wmertens June 9, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants