Skip to content

fix(core): throw when importing twice #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(core): throw when importing twice #7109

wants to merge 3 commits into from

Conversation

wmertens
Copy link
Member

@wmertens wmertens commented Nov 28, 2024

this should make it easier to detect build misconfigurations

Closes #3883

@wmertens wmertens requested a review from a team as a code owner November 28, 2024 12:14
@wmertens wmertens enabled auto-merge November 28, 2024 12:14
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: d77793c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@wmertens wmertens requested a review from a team as a code owner November 28, 2024 12:29
@wmertens wmertens force-pushed the warn-duplicate branch 4 times, most recently from 6ba9072 to 351bf38 Compare November 28, 2024 13:20
@gioboa gioboa disabled auto-merge November 28, 2024 13:22
gioboa
gioboa previously approved these changes Nov 28, 2024
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great to me @wmertens 🤖

Copy link
Contributor

github-actions bot commented Aug 4, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d77793c

Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7109
npm i https://pkg.pr.new/@builder.io/qwik-city@7109
npm i https://pkg.pr.new/eslint-plugin-qwik@7109
npm i https://pkg.pr.new/create-qwik@7109

commit: 32eb2be

@wmertens wmertens moved this from Backlog to Waiting For Review in Qwik Development Aug 4, 2025
gioboa
gioboa previously approved these changes Aug 4, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs dev is not working

@gioboa gioboa requested a review from a team as a code owner August 5, 2025 08:29
gioboa
gioboa previously approved these changes Aug 5, 2025
@wmertens wmertens force-pushed the warn-duplicate branch 2 times, most recently from 19b302c to 3eeb13c Compare August 5, 2025 09:12
@shairez
Copy link
Contributor

shairez commented Aug 5, 2025

@wmertens summary of our meeting:

  • Moving it to v2 instead of v1
  • Enhancing the error message to provide a more thorough solution

Thanks!

wmertens and others added 3 commits August 6, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

[🐞] Duplicate implementations of JSXNode Errors in RC, v0.103
3 participants