optimize(udp): use address type to filter wrong password early #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AEAD data can be partially decrypted *without check tag*, so we can see address type without decrypt full packet. Then we can use it to filter out 253/256 wrong situation.
mzz2017
approved these changes
Dec 31, 2020
|
Thanks for your hard work! I will add some unit test to verify its feasibility. |
|
All tests passed. |
|
crypto is hard. I go die. |
DuckSoft
approved these changes
Dec 31, 2020
… auth in MAC situation(MTU is 1500)
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AEAD data can be partially decrypted without check tag, so we can see address type without decrypt full packet. Then we can use it to filter out 253/256 wrong situation.
Note: Not tested
Note: Partially decrypt AEAD cipher text is not suggested, we lost integrity check when doing so.