Enabling RSpec/PendingWithoutReason (dependabot#9739)

Qureshi2131 · May 17, 2024 · cbd2974 · cbd2974
1 parent e65727b
commit cbd2974
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -326,12 +326,6 @@ RSpec/OverwritingSetup:
     - 'terraform/spec/dependabot/terraform/file_parser_spec.rb'
     - 'updater/spec/dependabot/dependency_snapshot_spec.rb'
 
-# Offense count: 2
-RSpec/PendingWithoutReason:
-  Exclude:
-    - 'bundler/spec/dependabot/bundler/update_checker_spec.rb'
-    - 'go_modules/spec/dependabot/go_modules/path_converter_spec.rb'
-
 # Offense count: 47
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers.

diff --git a/bundler/spec/dependabot/bundler/update_checker_spec.rb b/bundler/spec/dependabot/bundler/update_checker_spec.rb
@@ -1217,7 +1217,10 @@
       context "that is old" do
         let(:dependency_files) { bundler_project_dependency_files("explicit_ruby_old") }
 
-        xit { is_expected.to eq(Gem::Version.new("2.0.1")) }
+        it "Gem version is 2.0.1" do
+          skip "This test intermittently fails, which often trips up external contributors"
+          is_expected.to eq(Gem::Version.new("2.0.1"))
+        end
       end
     end
 

diff --git a/go_modules/spec/dependabot/go_modules/path_converter_spec.rb b/go_modules/spec/dependabot/go_modules/path_converter_spec.rb
@@ -30,7 +30,8 @@
       it { is_expected.to eq("https://github.com/kubernetes/apimachinery") }
     end
 
-    xcontext "with a vanity URL that redirects" do
+    context "with a vanity URL that redirects" do
+      skip "This test is temporarily disabled due to intermittent failures"
       let(:path) { "code.cloudfoundry.org/bytefmt" }
       it { is_expected.to eq("https://github.com/cloudfoundry/bytefmt") }
     end