Fix rubocops

Qureshi2131 · Jan 15, 2019 · 927659f · 927659f
1 parent 2fea827
commit 927659f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 14 deletions.
diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/npm_lockfile_updater.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/npm_lockfile_updater.rb
@@ -383,9 +383,7 @@ def replace_ssh_sources(content)
         end
 
         def git_ssh_requirements_to_swap
-          if @git_ssh_requirements_to_swap
-            return @git_ssh_requirements_to_swap
-          end
+          return @git_ssh_requirements_to_swap if @git_ssh_requirements_to_swap
 
           @git_ssh_requirements_to_swap = []
 

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/package_json_preparer.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/package_json_preparer.rb
@@ -66,9 +66,7 @@ def swapped_ssh_requirements
         attr_reader :package_json_content
 
         def git_ssh_requirements_to_swap
-          if @git_ssh_requirements_to_swap
-            return @git_ssh_requirements_to_swap
-          end
+          return @git_ssh_requirements_to_swap if @git_ssh_requirements_to_swap
 
           @git_ssh_requirements_to_swap = []
 

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/file_updater/yarn_lockfile_updater.rb
@@ -319,9 +319,7 @@ def remove_workspace_path_prefixes(content)
         end
 
         def git_ssh_requirements_to_swap
-          if @git_ssh_requirements_to_swap
-            return @git_ssh_requirements_to_swap
-          end
+          return @git_ssh_requirements_to_swap if @git_ssh_requirements_to_swap
 
           git_dependencies =
             dependencies.

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/requirements_updater.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/requirements_updater.rb
@@ -26,10 +26,7 @@ def initialize(requirements:, updated_source:, update_strategy:,
 
           check_update_strategy
 
-          if latest_version
-            @latest_version = version_class.new(latest_version)
-          end
-
+          @latest_version = version_class.new(latest_version) if latest_version
           return unless latest_resolvable_version
 
           @latest_resolvable_version =

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/version.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/version.rb
@@ -30,4 +30,5 @@ def to_s
   end
 end
 
-Dependabot::Utils.register_version_class("npm_and_yarn", Dependabot::NpmAndYarn::Version)
+Dependabot::Utils.
+  register_version_class("npm_and_yarn", Dependabot::NpmAndYarn::Version)