Fix async operation issue when used in ASP.NET #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Changing SendPacket to an async void method caused the following when used in an ASP.NET MVC application
Resolution:
Wait for the WaitForUpgrade task to complete synchronously and remove the async modifier from SendPacket.
Note:
The alternative to synchronously waiting is to propagate the async/await pattern up through all methods that call SendPacket, this is a much larger change than I am comfortable making at this point in time.