forked from flutter/flutter
-
Notifications
You must be signed in to change notification settings - Fork 0
Create Carousel widget - Part 2 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ab953 to
7910076
Compare
9 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just being protective here, but late can be avoided if it is nullable anyway?
I'd avoid the LateInitializationError where we can :)
de12e21 to
94fc715
Compare
b344639 to
78c96cd
Compare
bc0bad5 to
b1f83b1
Compare
5f8d535 to
25b81cf
Compare
25b81cf to
30b38b8
Compare
30b38b8 to
ecd846a
Compare
ecd846a to
f29e6aa
Compare
7b98c57 to
0fd9510
Compare
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 5, 2024
This PR is to create an ["uncontained" Carousel](https://m3.material.io/components/carousel/specs#477de3a1-c9df-4742-baf3-bcd5eeb3764c). https://github.com/flutter/flutter/assets/36861262/947e6b2c-219f-4c8b-aba1-4a1a010221a7 The rest of the layouts can be achieved by using `Carousel.weighted`: QuncCccccc#2. The branch of `Caorusel.weighted` PR is based on this PR for relatively easer review. Will request reviews for the part 2 PR once this one is successfully merged in master.
Owner
Author
|
Closing this one and will create another one to merge into upstream master. |
QuncCccccc
pushed a commit
that referenced
this pull request
Jul 29, 2024
Also update tests Attempt #2 of flutter#152048 cc: @cbracken
QuncCccccc
pushed a commit
that referenced
this pull request
Aug 22, 2024
When attempting to release the Flutter 3.24.1 hotfix, Flutter framework post submits failed due to the following error: ``` ���ERROR #1��������������������������������������������������������������������� � UNEXPECTED ERROR! � Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter � #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:150:12) � <asynchronous suspension> � #1 verifyCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:28:3) � <asynchronous suspension> � #2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:601:5) � <asynchronous suspension> � flutter#3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:125:5) � <asynchronous suspension> � � The test.dart script should be corrected to catch this error and call foundError(). � Some tests are likely to have been skipped. �������������������������������������������������������������������������������� ``` I've updated the tests to include the listed artifact. ### Open questions 1. Is it possible that the test failed only on the first binary? 2. Do we expect a need to add the remainder of the [entitlement changes](flutter/engine@c9b9d57)? 3. I am under the assumption that the bots pull from master and are not branch specific, is this a correct assumption? CC @christopherfujino @cbracken
QuncCccccc
pushed a commit
that referenced
this pull request
Sep 9, 2024
…lutter#154715) Fixes: flutter#154580 Previous PR: flutter#154677 More info: flutter#154580 (comment) The errors described in the original issue [are still occurring](flutter#154580 (comment)) after flutter#154677. Before this change, the repro [broken_demo](https://github.com/rajveermalviya/broken_demo) mentioned in the original issue logs: ```shell-session $ flutter run --release Launching lib/main.dart on sdk gphone64 arm64 in release mode... Running Gradle task 'assembleRelease'... 14.5s â�� Built build/app/outputs/flutter-apk/app-release.apk (7.4MB) Installing build/app/outputs/flutter-apk/app-release.apk... 739ms Flutter run key commands. h List all available interactive commands. c Clear the screen q Quit (terminate the application on the device). W/FlutterEngineCxnRegstry(13284): Attempted to register plugin (a0.a@53b33b6) but it was already registered with this FlutterEngine (d0.c@8baa8b7). E/flutter (13284): [ERROR:flutter/runtime/dart_vm_initializer.cc(40)] Unhandled Exception: PlatformException(channel-error, Unable to establish connection on channel., null, null) E/flutter (13284): #0 PathProviderApi.getApplicationSupportPath (package:path_provider_android/messages.g.dart:65) E/flutter (13284): <asynchronous suspension> E/flutter (13284): #1 getApplicationSupportDirectory (package:path_provider/path_provider.dart:78) E/flutter (13284): <asynchronous suspension> E/flutter (13284): #2 _BorkenDemoHomePageState.build.<anonymous closure> (package:broken_demo/main.dart:44) E/flutter (13284): <asynchronous suspension> E/flutter (13284): ``` After this change: ```shell-session $ flutter run --release Launching lib/main.dart on sdk gphone64 arm64 in release mode... Running Gradle task 'assembleRelease'... 15.2s â�� Built build/app/outputs/flutter-apk/app-release.apk (7.4MB) Installing build/app/outputs/flutter-apk/app-release.apk... 857ms Flutter run key commands. h List all available interactive commands. c Clear the screen q Quit (terminate the application on the device). I/flutter (13040): path_provider: Directory: '/data/user/0/com.example.broken_demo/files' ```
QuncCccccc
pushed a commit
that referenced
this pull request
Sep 10, 2024
…lutter#154904) flutter/engine@3dc8b71...8a038a6 2024-09-10 yjbanov@google.com [skwasm] use temporary RawPaint objects (attempt #2) (flutter/engine#55035) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC codefu@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
QuncCccccc
pushed a commit
that referenced
this pull request
Sep 12, 2024
flutter#154645) ### Problem Enabling the Swift Package Manager feature caused post-submit tests to fail on Mac x64 hosts: <details> <summary>Example error...</summary> https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20rrect_blur_perf_ios__timeline_summary/575/overview ``` â�¦ ... flutter --verbose assemble ... -dIosArchs=x86_64 ... profile_unpack_ios Target profile_unpack_ios failed: Exception: Binary ... build/ios/Profile-iphoneos/Flutter.framework/Flutter does not contain x86_64. Running lipo -info: Non-fat file: ... build/ios/Profile-iphoneos/Flutter.framework/Flutter is architecture: arm64 #0 UnpackIOS._thinFramework (package:flutter_tools/src/build_system/targets/ios.dart:351:7) <asynchronous suspension> #1 UnpackIOS.build (package:flutter_tools/src/build_system/targets/ios.dart:298:5) <asynchronous suspension> ... ``` </details> ### Reproduction On a mac x64 host: 1. Switch to the latest master channel: `flutter channel master ; flutter upgrade` 1. Disable the Swift Package Manager feature: `flutter config --no-enable-swift-package-manager` 2. Create a Flutter project 2. [Edit the Xcode project manually to add the prepare pre-action](https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-app-developers#step-2-add-run-prepare-flutter-framework-script-pre-action) 3. Run `flutter run` (`flutter build ios` does not reproduce this issue). ### Background Previously, the Flutter framework was unpacked in the Xcode target's build. Unfortunately, this happens after Swift packages are built; this prevented Swift packages from using the Flutter framework. To fix this, we added an Xcode pre-action that unpacks the Flutter framework _before_ Swift Package Manager builds packages. The Xcode target still runs the Flutter framework unpack step, but this step no-ops if the unpack step has the exact same inputs. ```mermaid flowchart LR A[flutter run -d iphone] --> B(Build Xcode project) B --> C(Xcode 'prepare framework' pre-action) B --> G[Build Swift packages] B --> D(Build 'Runner' target) C --> E[Unpack Flutter framework #1] D --> F[" Unpack Flutter framework #2 (No-ops if inputs are same as #1) "] ``` flutter#150052 added an optimization that made it more likely the second unpack step no-ops by fixing a case where the target architecture input could be different: > When using SwiftPM, we use `flutter assemble` in an Xcode Pre-action to run the `debug_unpack_macos` (or profile/release) target. This target is also later used in a Run Script build phase. Depending on `ARCHS` build setting, the Flutter/FlutterMacOS binary is thinned. In the Run Script build phase, `ARCHS` is filtered to the active arch. However, in the Pre-action it doesn't always filter to the active arch. As a workaround, assume arm64 if the [`NATIVE_ARCH`](https://developer.apple.com/documentation/xcode/build-settings-reference/#NATIVEARCH) is arm, otherwise assume x86_64. This optimization is only applied if [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) is `YES`. > [!IMPORTANT] > [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157)'s name is misleading. It specifies whether the product includes only object code for the native architecture. > > A value of `YES` means the product includes only code for the native architecture ([NATIVE_ARCH](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW59)). > > A value of `NO` means the product includes code for the architectures specified in [ARCHS (Architectures)](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW62). ### Problem `buildXcodeProject` incorrectly always sets `ONLY_ACTIVE_ARCH` to `YES` if the Xcode built is for a single architecture: https://github.com/flutter/flutter/blob/6abef222514e8039bde5c47ab7864abbc4caf7e8/packages/flutter_tools/lib/src/ios/mac.dart#L353-L361 This is incorrect! If the host architecture is `x64` but the target architecture is `arm64`, [`ONLY_ACTIVE_ARCH`](https://developer.apple.com/library/archive/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/1-Build_Setting_Reference/build_setting_ref.html#//apple_ref/doc/uid/TP40003931-CH3-SW157) should be `NO`. This caused the prepare pre-action to incorrectly use x64 as the target architecture for arm64 devices on an x64 host, which in turn caused builds to fail if Swift Package Manager was enabled. ### Solution This change updates `buildXcodeProject` to set `ONLY_ACTIVE_ARCH` correctly. This change also updates the prepare pre-action's to be more conservative in applying the optimization that filters the target architecture. This ensures that the build still works (but without the optimization) if `ONLY_ACTIVE_ARCH` is incorrectly set. Follow-up PR: flutter#154649 This unblocks: flutter#151567 ### DeviceLab test This problem reproduces if you `flutter run` to an iPhone Arm64 device from an x64 mac host with the Swift Package Manager feature enabled. I ran an affected DeviceLab test to verify the fix works as expected: Description | CI test | Result -- | -- | -- SwiftPM enabled without this fix: flutter#154750 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/7/overview) | â�� SwiftPM enabled with this fix: flutter#154749 | [Link](https://ci.chromium.org/ui/p/flutter/builders/try.shadow/Mac_ios%20rrect_blur_perf_ios__timeline_summary/8/overview) | â�
QuncCccccc
pushed a commit
that referenced
this pull request
Sep 30, 2024
follow up for : [flutter#152073](flutter#152073)
QuncCccccc
pushed a commit
that referenced
this pull request
Feb 14, 2025
The crash indicates that FlutterJNI is returning a nullptr SurfaceControl.Transaction. That likely indicates that we're trying to rasterize a frame before the platform view controller is setup. Potentially a startup race? At any rate, if the PVC is null that means there is no platform views - so it should be safe to create a tx on the fly. Interestingly I cannot repro this locally even on the same device. ``` [2025-02-11 21:50:37.462356] [STDOUT] stdout: [ +173 ms] *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** [2025-02-11 21:50:37.462539] [STDOUT] stdout: [ ] Build fingerprint: 'google/cheetah/cheetah:13/TQ3A.230901.001/10750268:user/release-keys' [2025-02-11 21:50:37.462564] [STDOUT] stdout: [ ] Revision: 'MP1.0' [2025-02-11 21:50:37.463914] [STDOUT] stdout: [ +1 ms] ABI: 'arm64' [2025-02-11 21:50:37.463946] [STDOUT] stdout: [ ] Timestamp: 2025-02-11 21:57:42.183302140-0800 [2025-02-11 21:50:37.463959] [STDOUT] stdout: [ ] Process uptime: 3s [2025-02-11 21:50:37.464054] [STDOUT] stdout: [ ] Cmdline: dev.benchmarks.platform_views_layout [2025-02-11 21:50:37.464174] [STDOUT] stdout: [ ] pid: 15185, tid: 15246, name: 1.raster >>> dev.benchmarks.platform_views_layout <<< [2025-02-11 21:50:37.464354] [STDOUT] stdout: [ ] uid: 10250 [2025-02-11 21:50:37.464398] [STDOUT] stdout: [ ] tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE) [2025-02-11 21:50:37.464440] [STDOUT] stdout: [ ] signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000 [2025-02-11 21:50:37.464602] [STDOUT] stdout: [ ] Cause: null pointer dereference [2025-02-11 21:50:37.464651] [STDOUT] stdout: [ ] x0 b400007b82ff2e70 x1 000000000000002d x2 b400007c3309f370 x3 0000007abbcc6a23 [2025-02-11 21:50:37.464745] [STDOUT] stdout: [ ] x4 0000007a30d286b0 x5 0000007a4f6dd47b x6 0000000000000000 x7 61686b4b11ff3a78 [2025-02-11 21:50:37.464831] [STDOUT] stdout: [ ] x8 0000000000000000 x9 1417c2bd490e1f78 x10 0000000000000010 x11 000000000000009c [2025-02-11 21:50:37.464933] [STDOUT] stdout: [ ] x12 0000000000000adb x13 b400007ba2fe9510 x14 0000000000000e6b x15 b400007ba2fe9510 [2025-02-11 21:50:37.465012] [STDOUT] stdout: [ ] x16 0000000000000001 x17 0000000000000067 x18 0000007a2f996000 x19 b400007b82ff2e70 [2025-02-11 21:50:37.465082] [STDOUT] stdout: [ ] x20 000000000000002d x21 b400007ae3064b60 x22 b400007af30d0fa8 x23 0000000000000001 [2025-02-11 21:50:37.465155] [STDOUT] stdout: [ ] x24 0000007a30d2a000 x25 b400007b73028fb0 x26 0000007a3a22da20 x27 000000003b9bf6c8 [2025-02-11 21:50:37.465235] [STDOUT] stdout: [ ] x28 b400007af30d0fa8 x29 b400007ad3022cd0 [2025-02-11 21:50:37.465318] [STDOUT] stdout: [ ] lr 0000007a3a8c7918 sp 0000007a30d28940 pc 0000000000000000 pst 0000000040001000 [2025-02-11 21:50:37.465401] [STDOUT] stdout: [ ] backtrace: [2025-02-11 21:50:37.465491] [STDOUT] stdout: [ ] #00 pc 0000000000000000 <unknown> [2025-02-11 21:50:37.465596] [STDOUT] stdout: [ ] #1 pc 000000000088b914 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::PlatformViewAndroidJNIImpl::createTransaction()+104) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465688] [STDOUT] stdout: [ ] #2 pc 000000000087f738 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0, std::_fl::allocator<flutter::AndroidSurfaceVKImpeller::SetNativeWindow(fml::RefPtr<flutter::AndroidNativeWindow>, std::_fl::shared_ptr<flutter::PlatformViewAndroidJNI> const&)::$_0>, impeller::android::SurfaceTransaction ()>::operator()()+16) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465785] [STDOUT] stdout: [ ] flutter#3 pc 0000000000bdbf1c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0, std::_fl::allocator<impeller::AHBSwapchainImplVK::AcquireNextDrawable()::$_0>, bool ()>::operator()()+1716) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465874] [STDOUT] stdout: [ ] flutter#4 pc 0000000000b1d180 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::SurfaceFrame::Submit()+148) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.465989] [STDOUT] stdout: [ ] flutter#5 pc 0000000000beb2b4 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfacesUnsafe(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+1284) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466400] [STDOUT] stdout: [ ] flutter#6 pc 0000000000beac58 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::DrawToSurfaces(flutter::FrameTimingsRecorder&, std::_fl::vector<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> >, std::_fl::allocator<std::_fl::unique_ptr<flutter::LayerTreeTask, std::_fl::default_delete<flutter::LayerTreeTask> > > >)+112) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466444] [STDOUT] stdout: [ ] flutter#7 pc 0000000000bec144 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0, std::_fl::allocator<flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)::$_0>, void (std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >)>::operator()(std::_fl::unique_ptr<flutter::FrameItem, std::_fl::default_delete<flutter::FrameItem> >&&)+192) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466468] [STDOUT] stdout: [ ] flutter#8 pc 0000000000bebc48 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (flutter::Rasterizer::Draw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> > const&)+360) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466521] [STDOUT] stdout: [ ] flutter#9 pc 0000000000bf9f7c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0>, std::_fl::allocator<fml::internal::CopyableLambda<flutter::Shell::OnAnimatorDraw(std::_fl::shared_ptr<flutter::Pipeline<flutter::FrameItem> >)::$_0> >, void ()>::operator()()+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466543] [STDOUT] stdout: [ ] flutter#10 pc 00000000008a09ec /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopImpl::RunExpiredTasksNow()+728) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466667] [STDOUT] stdout: [ ] flutter#11 pc 00000000008a4600 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)+84) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466746] [STDOUT] stdout: [ ] flutter#12 pc 0000000000011178 /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+808) (BuildId: 0b4a793fa8045c04066d988c68bac8bb) [2025-02-11 21:50:37.466784] [STDOUT] stdout: [ ] flutter#13 pc 00000000000185e4 /system/lib64/libandroid.so (ALooper_pollOnce+100) (BuildId: 682dab490c18361d5d6527bcdd86cdfa) [2025-02-11 21:50:37.466865] [STDOUT] stdout: [ ] flutter#14 pc 00000000008a470c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::MessageLoopAndroid::Run()+28) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466903] [STDOUT] stdout: [ ] flutter#15 pc 00000000008a283c /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (std::_fl::__function::__func<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0, std::_fl::allocator<fml::Thread::Thread(std::_fl::function<void (fml::Thread::ThreadConfig const&)> const&, fml::Thread::ThreadConfig const&)::$_0>, void ()>::operator()()+116) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.466943] [STDOUT] stdout: [ ] flutter#16 pc 00000000008a2670 /data/app/~~u9nRjz4bI1GoKFecw6gtbg==/dev.benchmarks.platform_views_layout-RoPBoOldhc38L7sINb2Vgg==/lib/arm64/libflutter.so (fml::ThreadHandle::ThreadHandle(std::_fl::function<void ()>&&)::$_0::__invoke(void*)+8) (BuildId: 8fab16f9507483301ef418db2c91ed06689696b1) [2025-02-11 21:50:37.467002] [STDOUT] stdout: [ ] flutter#17 pc 00000000000c226c /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+204) (BuildId: dc4001c2ef2dfc23467040797a96840c) [2025-02-11 21:50:37.467058] [STDOUT] stdout: [ ] flutter#18 pc 0000000000054a30 /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: dc4001c2ef2dfc23467040797a96840c) [2025-02-11 21:50:37.525275] [STDOUT] stdout: [ +57 ms] 00:00 �[32m+0�[0m�[31m -1�[0m: scrolling performance test (setUpAll) �[1m�[31m[E]�[0m�[0m ```
QuncCccccc
pushed a commit
that referenced
this pull request
Apr 10, 2025
Currently when using a `CustomScrollView`, screen readers cannot list or
move focus to elements that are outside the current Viewport and cache
extent because we do not create semantic nodes for these elements.
This change introduces `SliverEnsureSemantics` which ensures its sliver
child is included in the semantics tree, whether or not it is currently
visible on the screen or within the cache extent. This way screen
readers are aware the elements are there and can navigate to them /
create accessibility traversal menus with this information.
* Under the hood a new flag has been added to `RenderSliver` called
`ensureSemantics`. `RenderViewportBase` uses this in its
`visitChildrenForSemantics` to ensure a sliver is visited when creating
the semantics tree. Previously a sliver was not visited if it was not
visible or within the cache extent. `RenderViewportBase` also uses this
in `describeSemanticsClip` and `describeApproximatePaintClip` to ensure
a sliver child that wants to "ensure semantics" is not clipped out if it
is not currently visible in the viewport or outside the cache extent.
* `RenderSliverMultiBoxAdaptor.semanticBounds` now leverages its first
child as an anchor for assistive technologies to be able to reach it if
the Sliver is a child of `SliverEnsureSemantics`. If not it will still
be dropped from the semantics tree.
* `RenderProxySliver` now considers child overrides of `semanticBounds`.
On the engine side we move from using a joystick method to scroll with
`SemanticsAction.scrollUp` and `SemanticsAction.scrollDown` to using
`SemanticsAction.scrollToOffset` completely letting the browser drive
the scrolling with its current dom scroll position "scrollTop" or
"scrollLeft". This is possible by calculating the total quantity of
content under the scrollable and sizing the scroll element based on
that.
<details open><summary>Code sample</summary>
```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
/// Flutter code sample for [SliverEnsureSemantics].
void main() => runApp(const SliverEnsureSemanticsExampleApp());
class SliverEnsureSemanticsExampleApp extends StatelessWidget {
const SliverEnsureSemanticsExampleApp({super.key});
@OverRide
Widget build(BuildContext context) {
return const MaterialApp(home: SliverEnsureSemanticsExample());
}
}
class SliverEnsureSemanticsExample extends StatefulWidget {
const SliverEnsureSemanticsExample({super.key});
@OverRide
State<SliverEnsureSemanticsExample> createState() =>
_SliverEnsureSemanticsExampleState();
}
class _SliverEnsureSemanticsExampleState
extends State<SliverEnsureSemanticsExample> {
@OverRide
Widget build(BuildContext context) {
final ThemeData theme = Theme.of(context);
return Scaffold(
appBar: AppBar(
backgroundColor: theme.colorScheme.inversePrimary,
title: const Text('SliverEnsureSemantics Demo'),
),
body: Center(
child: CustomScrollView(
semanticChildCount: 106,
slivers: <Widget>[
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 0,
child: Card(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: <Widget>[
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Steps to reproduce',
style: theme.textTheme.headlineSmall,
),
),
const Text('Issue description'),
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Expected Results',
style: theme.textTheme.headlineSmall,
),
),
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Actual Results',
style: theme.textTheme.headlineSmall,
),
),
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Code Sample',
style: theme.textTheme.headlineSmall,
),
),
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Screenshots',
style: theme.textTheme.headlineSmall,
),
),
Semantics(
header: true,
headingLevel: 3,
child: Text(
'Logs',
style: theme.textTheme.headlineSmall,
),
),
],
),
),
),
),
),
),
SliverFixedExtentList(
itemExtent: 44.0,
delegate: SliverChildBuilderDelegate(
(BuildContext context, int index) {
return Card(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text('Item $index'),
),
);
},
childCount: 50,
semanticIndexOffset: 1,
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 51,
child: Card(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Semantics(
header: true,
child: const Text('Footer 1'),
),
),
),
),
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 52,
child: Card(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Semantics(
header: true,
child: const Text('Footer 2'),
),
),
),
),
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 53,
child: Semantics(link: true, child: const Text('Link #1')),
),
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 54,
child: OverflowBar(
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
],
),
),
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 55,
child: Semantics(link: true, child: const Text('Link #2')),
),
),
),
SliverEnsureSemantics(
sliver: SliverSemanticsList(
sliver: SliverFixedExtentList(
itemExtent: 44.0,
delegate: SliverChildBuilderDelegate(
(BuildContext context, int index) {
return Semantics(
role: SemanticsRole.listItem,
child: Card(
child: Padding(
padding: const EdgeInsets.all(8.0),
child: Text('Second List Item $index'),
),
),
);
},
childCount: 50,
semanticIndexOffset: 56,
),
),
),
),
SliverEnsureSemantics(
sliver: SliverToBoxAdapter(
child: IndexedSemantics(
index: 107,
child: Semantics(link: true, child: const Text('Link flutter#3')),
),
),
),
],
),
),
);
}
}
// A sliver that assigns the role of SemanticsRole.list to its sliver child.
class SliverSemanticsList extends SingleChildRenderObjectWidget {
const SliverSemanticsList({super.key, required Widget sliver})
: super(child: sliver);
@OverRide
RenderSliverSemanticsList createRenderObject(BuildContext context) =>
RenderSliverSemanticsList();
}
class RenderSliverSemanticsList extends RenderProxySliver {
@OverRide
void describeSemanticsConfiguration(SemanticsConfiguration config) {
super.describeSemanticsConfiguration(config);
config.role = SemanticsRole.list;
}
}
```
</details>
Fixes: flutter#160217
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Renzo Olivares <roliv@google.com>
QuncCccccc
pushed a commit
that referenced
this pull request
Apr 10, 2025
<!-- start_original_pr_link --> Reverts: flutter#165589 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: Renzo-Olivares <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: breaking internal tests <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: Renzo-Olivares <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {Piinks} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: Currently when using a `CustomScrollView`, screen readers cannot list or move focus to elements that are outside the current Viewport and cache extent because we do not create semantic nodes for these elements. This change introduces `SliverEnsureSemantics` which ensures its sliver child is included in the semantics tree, whether or not it is currently visible on the screen or within the cache extent. This way screen readers are aware the elements are there and can navigate to them / create accessibility traversal menus with this information. * Under the hood a new flag has been added to `RenderSliver` called `ensureSemantics`. `RenderViewportBase` uses this in its `visitChildrenForSemantics` to ensure a sliver is visited when creating the semantics tree. Previously a sliver was not visited if it was not visible or within the cache extent. `RenderViewportBase` also uses this in `describeSemanticsClip` and `describeApproximatePaintClip` to ensure a sliver child that wants to "ensure semantics" is not clipped out if it is not currently visible in the viewport or outside the cache extent. * `RenderSliverMultiBoxAdaptor.semanticBounds` now leverages its first child as an anchor for assistive technologies to be able to reach it if the Sliver is a child of `SliverEnsureSemantics`. If not it will still be dropped from the semantics tree. * `RenderProxySliver` now considers child overrides of `semanticBounds`. On the engine side we move from using a joystick method to scroll with `SemanticsAction.scrollUp` and `SemanticsAction.scrollDown` to using `SemanticsAction.scrollToOffset` completely letting the browser drive the scrolling with its current dom scroll position "scrollTop" or "scrollLeft". This is possible by calculating the total quantity of content under the scrollable and sizing the scroll element based on that. <details open><summary>Code sample</summary> ```dart // Copyright 2014 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; /// Flutter code sample for [SliverEnsureSemantics]. void main() => runApp(const SliverEnsureSemanticsExampleApp()); class SliverEnsureSemanticsExampleApp extends StatelessWidget { const SliverEnsureSemanticsExampleApp({super.key}); @OverRide Widget build(BuildContext context) { return const MaterialApp(home: SliverEnsureSemanticsExample()); } } class SliverEnsureSemanticsExample extends StatefulWidget { const SliverEnsureSemanticsExample({super.key}); @OverRide State<SliverEnsureSemanticsExample> createState() => _SliverEnsureSemanticsExampleState(); } class _SliverEnsureSemanticsExampleState extends State<SliverEnsureSemanticsExample> { @OverRide Widget build(BuildContext context) { final ThemeData theme = Theme.of(context); return Scaffold( appBar: AppBar( backgroundColor: theme.colorScheme.inversePrimary, title: const Text('SliverEnsureSemantics Demo'), ), body: Center( child: CustomScrollView( semanticChildCount: 106, slivers: <Widget>[ SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 0, child: Card( child: Padding( padding: const EdgeInsets.all(8.0), child: Column( crossAxisAlignment: CrossAxisAlignment.start, children: <Widget>[ Semantics( header: true, headingLevel: 3, child: Text( 'Steps to reproduce', style: theme.textTheme.headlineSmall, ), ), const Text('Issue description'), Semantics( header: true, headingLevel: 3, child: Text( 'Expected Results', style: theme.textTheme.headlineSmall, ), ), Semantics( header: true, headingLevel: 3, child: Text( 'Actual Results', style: theme.textTheme.headlineSmall, ), ), Semantics( header: true, headingLevel: 3, child: Text( 'Code Sample', style: theme.textTheme.headlineSmall, ), ), Semantics( header: true, headingLevel: 3, child: Text( 'Screenshots', style: theme.textTheme.headlineSmall, ), ), Semantics( header: true, headingLevel: 3, child: Text( 'Logs', style: theme.textTheme.headlineSmall, ), ), ], ), ), ), ), ), ), SliverFixedExtentList( itemExtent: 44.0, delegate: SliverChildBuilderDelegate( (BuildContext context, int index) { return Card( child: Padding( padding: const EdgeInsets.all(8.0), child: Text('Item $index'), ), ); }, childCount: 50, semanticIndexOffset: 1, ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 51, child: Card( child: Padding( padding: const EdgeInsets.all(8.0), child: Semantics( header: true, child: const Text('Footer 1'), ), ), ), ), ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 52, child: Card( child: Padding( padding: const EdgeInsets.all(8.0), child: Semantics( header: true, child: const Text('Footer 2'), ), ), ), ), ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 53, child: Semantics(link: true, child: const Text('Link #1')), ), ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 54, child: OverflowBar( children: <Widget>[ TextButton( onPressed: () {}, child: const Text('Button 1'), ), TextButton( onPressed: () {}, child: const Text('Button 2'), ), ], ), ), ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 55, child: Semantics(link: true, child: const Text('Link #2')), ), ), ), SliverEnsureSemantics( sliver: SliverSemanticsList( sliver: SliverFixedExtentList( itemExtent: 44.0, delegate: SliverChildBuilderDelegate( (BuildContext context, int index) { return Semantics( role: SemanticsRole.listItem, child: Card( child: Padding( padding: const EdgeInsets.all(8.0), child: Text('Second List Item $index'), ), ), ); }, childCount: 50, semanticIndexOffset: 56, ), ), ), ), SliverEnsureSemantics( sliver: SliverToBoxAdapter( child: IndexedSemantics( index: 107, child: Semantics(link: true, child: const Text('Link flutter#3')), ), ), ), ], ), ), ); } } // A sliver that assigns the role of SemanticsRole.list to its sliver child. class SliverSemanticsList extends SingleChildRenderObjectWidget { const SliverSemanticsList({super.key, required Widget sliver}) : super(child: sliver); @OverRide RenderSliverSemanticsList createRenderObject(BuildContext context) => RenderSliverSemanticsList(); } class RenderSliverSemanticsList extends RenderProxySliver { @OverRide void describeSemanticsConfiguration(SemanticsConfiguration config) { super.describeSemanticsConfiguration(config); config.role = SemanticsRole.list; } } ``` </details> Fixes: flutter#160217 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
QuncCccccc
pushed a commit
that referenced
this pull request
Apr 21, 2025
Fixes error found in rolling to google.
```
[☠] Android toolchain - develop for Android devices (the doctor check crashed)
✗ Due to an error, the doctor check did not complete. If the error message
below is not helpful, please let us know about this issue at
https://github.com/flutter/flutter/issues.
✗ type 'Null' is not a subtype of type 'String' of 'executable'
• #0 LocalProcessManager.canRun
(package:process/src/interface/local_process_manager.dart:124)
#1 getEmulatorVersion
(package:flutter_tools/src/android/android_workflow.dart:64)
#2 AndroidValidator.validateImpl
(package:flutter_tools/src/android/android_workflow.dart:200)
flutter#3 DoctorValidator.validate
(package:flutter_tools/src/doctor_validator.dart:58)
flutter#4 Doctor.startValidatorTasks.<anonymous closure>
(package:flutter_tools/src/doctor.dart:244)
flutter#5 asyncGuard.<anonymous closure>
(package:flutter_tools/src/base/async_guard.dart:109)
flutter#6 _rootRun (dart:async/zone.dart:1525)
flutter#7 _CustomZone.run (dart:async/zone.dart:1422)
flutter#8 _runZoned (dart:async/zone.dart:2033)
flutter#9 runZonedGuarded (dart:async/zone.dart:2019)
flutter#10 runZoned (dart:async/zone.dart:1952)
flutter#11 asyncGuard (package:flutter_tools/src/base/async_guard.dart:106)
flutter#12 Doctor.startValidatorTasks
(package:flutter_tools/src/doctor.dart:234)
flutter#13 Doctor.diagnose (package:flutter_tools/src/doctor.dart:372)
flutter#14 DoctorCommand.runCommand
(package:flutter_tools/src/commands/doctor.dart:59)
flutter#15 FlutterCommand.verifyThenRunCommand
(package:flutter_tools/src/runner/flutter_command.dart:1897)
<asynchronous suspension>
flutter#16 FlutterCommand.run.<anonymous closure>
(package:flutter_tools/src/runner/flutter_command.dart:1551)
<asynchronous suspension>
flutter#17 AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:154)
<asynchronous suspension>
flutter#18 CommandRunner.runCommand (package:args/command_runner.dart:212)
<asynchronous suspension>
flutter#19 FlutterCommandRunner.runCommand.<anonymous closure>
(package:flutter_tools/src/runner/flutter_command_runner.dart:501)
<asynchronous suspension>
flutter#20 AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:154)
<asynchronous suspension>
flutter#21 FlutterCommandRunner.runCommand
(package:flutter_tools/src/runner/flutter_command_runner.dart:438)
<asynchronous suspension>
flutter#22 run.<anonymous closure>.<anonymous closure>
(package:flutter_tools/runner.dart:98)
<asynchronous suspension>
flutter#23 AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:154)
<asynchronous suspension>
flutter#24 AppContext.run.<anonymous closure>
(package:flutter_tools/src/base/context.dart:154)
<asynchronous suspension>
flutter#25 run (package:mobile.flutter.cli/flutter_tools.dart:106)
<asynchronous suspension>
flutter#26 main (google3:///mobile/flutter/cli/bin/cli_usage_aot.dart:4)
```
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
QuncCccccc
pushed a commit
that referenced
this pull request
Jun 4, 2025
https://dart.googlesource.com/sdk.git/+log/6aeb798bdbe2..239174405ad0 [2391744](https://dart.googlesource.com/sdk.git/+/239174405ad089da5f6063c8c002efbbd354b0b0) [Version 3.9.0-196.0.dev](https://dart.googlesource.com/sdk.git/+/239174405ad089da5f6063c8c002efbbd354b0b0) by Dart CI · 8 hours ago [3.9.0-196.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-196.0.dev) [3185cce](https://dart.googlesource.com/sdk.git/+/3185cce718a437a9b93fb6d0bd2ddbaaeda49494) [Version 3.9.0-195.0.dev](https://dart.googlesource.com/sdk.git/+/3185cce718a437a9b93fb6d0bd2ddbaaeda49494) by Dart CI · 22 hours ago [3.9.0-195.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-195.0.dev) [018ad19](https://dart.googlesource.com/sdk.git/+/018ad19e3efffaf7188093cad8b0868734ebfd4f) [Elements. Make LibraryFragment not Annotatable.](https://dart.googlesource.com/sdk.git/+/018ad19e3efffaf7188093cad8b0868734ebfd4f) by Konstantin Shcheglov · 22 hours ago [338a83a](https://dart.googlesource.com/sdk.git/+/338a83af8925036cbc24bd8c298d9b091513e6f6) [Update DevTools rev to 73eadd3be6eff2ddd9c7673f855f327a80111ebb](https://dart.googlesource.com/sdk.git/+/338a83af8925036cbc24bd8c298d9b091513e6f6) by Kenzie Davisson · 22 hours ago [44e0d32](https://dart.googlesource.com/sdk.git/+/44e0d326a75c3ebc491c7681e1e37c842f7f2991) [[ddc] Fix expression evaluation with wildcards](https://dart.googlesource.com/sdk.git/+/44e0d326a75c3ebc491c7681e1e37c842f7f2991) by Nicholas Shahan · 23 hours ago [c008be6](https://dart.googlesource.com/sdk.git/+/c008be6c4aad70557e793254771feb0015649103) [Elements. Remove FragmentImpl.name, pass name2 into constructors.](https://dart.googlesource.com/sdk.git/+/c008be6c4aad70557e793254771feb0015649103) by Konstantin Shcheglov · 23 hours ago [e12e916](https://dart.googlesource.com/sdk.git/+/e12e9160411a79be598160d32f459f6b3a173c4c) [Fix a bug on the diagnostic pages](https://dart.googlesource.com/sdk.git/+/e12e9160411a79be598160d32f459f6b3a173c4c) by Brian Wilkerson · 23 hours ago [91ae0bf](https://dart.googlesource.com/sdk.git/+/91ae0bfbcf822535e041be22bdd929bfb1920554) [Analyzer DATA_VERSION++](https://dart.googlesource.com/sdk.git/+/91ae0bfbcf822535e041be22bdd929bfb1920554) by Konstantin Shcheglov · 23 hours ago [72ee544](https://dart.googlesource.com/sdk.git/+/72ee5445c34a0c9c6594ac9ef3ea3f84e310bdf2) [[build] Install dartaotruntime to /usr/bin in the Debian package.](https://dart.googlesource.com/sdk.git/+/72ee5445c34a0c9c6594ac9ef3ea3f84e310bdf2) by Ryan Macnak · 24 hours ago [9f0e522](https://dart.googlesource.com/sdk.git/+/9f0e5229fa1cf0769da9d84896670a2e93e229ce) [[flow analysis] Fix layering of type promotions in try/finally.](https://dart.googlesource.com/sdk.git/+/9f0e5229fa1cf0769da9d84896670a2e93e229ce) by Paul Berry · 25 hours ago [5f9c5da](https://dart.googlesource.com/sdk.git/+/5f9c5da23871fe4a232b80c91f021104755e70e0) [[analysis_server] Dot shorthands: Find element references tests.](https://dart.googlesource.com/sdk.git/+/5f9c5da23871fe4a232b80c91f021104755e70e0) by Kallen Tu · 25 hours ago [4580a03](https://dart.googlesource.com/sdk.git/+/4580a03480d62c1a178eb6563fdb8dfc813f0dc0) [Roll dartdoc to 4ceea6b8240bf1dd9694a170368264e40c67d66b](https://dart.googlesource.com/sdk.git/+/4580a03480d62c1a178eb6563fdb8dfc813f0dc0) by Konstantin Shcheglov · 25 hours ago [1b310ca](https://dart.googlesource.com/sdk.git/+/1b310ca55bddb573a8287fa8f7b13dff92133a5b) [Version 3.9.0-194.0.dev](https://dart.googlesource.com/sdk.git/+/1b310ca55bddb573a8287fa8f7b13dff92133a5b) by Dart CI · 26 hours ago [3.9.0-194.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-194.0.dev) [03301c9](https://dart.googlesource.com/sdk.git/+/03301c9bfb94b59f8fbd46d504ef6f7b24be16bf) [[vm] Support assembly output for Windows.](https://dart.googlesource.com/sdk.git/+/03301c9bfb94b59f8fbd46d504ef6f7b24be16bf) by Ryan Macnak · 27 hours ago [bd9ab13](https://dart.googlesource.com/sdk.git/+/bd9ab13a38aca713f981ff397f8f4e57d2a405f2) [Remove underused exports from analyzer.dart](https://dart.googlesource.com/sdk.git/+/bd9ab13a38aca713f981ff397f8f4e57d2a405f2) by Sam Rawlins · 27 hours ago [70c4bcd](https://dart.googlesource.com/sdk.git/+/70c4bcd7cbb1a446f93bc815f67eb166f8409bc1) [linter: Clean up dead test code](https://dart.googlesource.com/sdk.git/+/70c4bcd7cbb1a446f93bc815f67eb166f8409bc1) by Sam Rawlins · 27 hours ago [86341c9](https://dart.googlesource.com/sdk.git/+/86341c9b8a192733d0d2d254651f6facd1ebc240) [[vm/gardening] Skip isolate_group_shared_send_test on fuchsia.](https://dart.googlesource.com/sdk.git/+/86341c9b8a192733d0d2d254651f6facd1ebc240) by Alexander Aprelev · 27 hours ago [9fc86d9](https://dart.googlesource.com/sdk.git/+/9fc86d963caa8523ac80a3839cd6e33168c0cb24) [Elements. Store MetadataImpl in ElementDirectiveImpl.](https://dart.googlesource.com/sdk.git/+/9fc86d963caa8523ac80a3839cd6e33168c0cb24) by Konstantin Shcheglov · 27 hours ago [a5520d0](https://dart.googlesource.com/sdk.git/+/a5520d07cb978ff02d6a956315af574f501f355c) [analyzer: Expand BlazeWorkspacePackage.isInTestDirectory to include 'testing'](https://dart.googlesource.com/sdk.git/+/a5520d07cb978ff02d6a956315af574f501f355c) by Sam Rawlins · 28 hours ago [ef7e045](https://dart.googlesource.com/sdk.git/+/ef7e045bfdf3b92b72b9702e268994165954de5e) [Elements. Remove metadata3, store MetadataImpl directly.](https://dart.googlesource.com/sdk.git/+/ef7e045bfdf3b92b72b9702e268994165954de5e) by Konstantin Shcheglov · 28 hours ago [36262e7](https://dart.googlesource.com/sdk.git/+/36262e7339e6180e531b699d7ca1836b277ea286) [Revert "[dart2wasm] Remove FunctionNode dependency from ClosureDynamicEntryGenerator"](https://dart.googlesource.com/sdk.git/+/36262e7339e6180e531b699d7ca1836b277ea286) by Jason Simmons · 28 hours ago [5663697](https://dart.googlesource.com/sdk.git/+/56636971dc4e38517fa55f0cb69321355c2511af) [[test_runner] Remove nnbd mode options.](https://dart.googlesource.com/sdk.git/+/56636971dc4e38517fa55f0cb69321355c2511af) by Ryan Macnak · 28 hours ago [8711f55](https://dart.googlesource.com/sdk.git/+/8711f552fd7675b87294e4b7c6217c544ee65061) [[deps] rev ecosystem, protobuf, test, tools, webdev, webdriver](https://dart.googlesource.com/sdk.git/+/8711f552fd7675b87294e4b7c6217c544ee65061) by Devon Carew · 28 hours ago [bf6ddd2](https://dart.googlesource.com/sdk.git/+/bf6ddd25c4b19795ec75bb067b83fdc370162f3a) [[flow analysis] Do not promote to mutual subtypes.](https://dart.googlesource.com/sdk.git/+/bf6ddd25c4b19795ec75bb067b83fdc370162f3a) by Paul Berry · 28 hours ago [73a85ec](https://dart.googlesource.com/sdk.git/+/73a85ec19513c46f6e6989b41d1fb3cdc79e0f61) [Elements. Deprecate FragmentImpl.name](https://dart.googlesource.com/sdk.git/+/73a85ec19513c46f6e6989b41d1fb3cdc79e0f61) by Konstantin Shcheglov · 28 hours ago [65d0d85](https://dart.googlesource.com/sdk.git/+/65d0d8581ac434f64c77fb1aae820e77dc148cc5) [[vm/shared] Move forward_table from Isolate to Thread.](https://dart.googlesource.com/sdk.git/+/65d0d8581ac434f64c77fb1aae820e77dc148cc5) by Alexander Aprelev · 29 hours ago [af0dba8](https://dart.googlesource.com/sdk.git/+/af0dba8e60e323aebd6cdd1b71b2740be9638762) [Version 3.9.0-193.0.dev](https://dart.googlesource.com/sdk.git/+/af0dba8e60e323aebd6cdd1b71b2740be9638762) by Dart CI · 30 hours ago [3.9.0-193.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-193.0.dev) [df12659](https://dart.googlesource.com/sdk.git/+/df126594e9e3a3ab2b57e394ed8452f474e75505) [[co19] Roll co19 to 3388e8e9073d57e6fdca6582568fdfa6f9a6bc61](https://dart.googlesource.com/sdk.git/+/df126594e9e3a3ab2b57e394ed8452f474e75505) by Sergey G. Grekhov · 30 hours ago [2565128](https://dart.googlesource.com/sdk.git/+/2565128cb0b7ca5e7d6eac321a7a83ba8494023b) [[infra] Shard Mac AOT builders.](https://dart.googlesource.com/sdk.git/+/2565128cb0b7ca5e7d6eac321a7a83ba8494023b) by Ryan Macnak · 30 hours ago [4fb105e](https://dart.googlesource.com/sdk.git/+/4fb105e7944ef99cae10b16c7309cee4e5c2f2e4) [[build] Debian package test.](https://dart.googlesource.com/sdk.git/+/4fb105e7944ef99cae10b16c7309cee4e5c2f2e4) by Ryan Macnak · 31 hours ago [5df7479](https://dart.googlesource.com/sdk.git/+/5df74796336e6c6be7e55c304fa6ce34da76fa96) [Reorganize the status/diagnostic pages](https://dart.googlesource.com/sdk.git/+/5df74796336e6c6be7e55c304fa6ce34da76fa96) by Brian Wilkerson · 31 hours ago [c006202](https://dart.googlesource.com/sdk.git/+/c006202dc6d314d9f7d035cef2c15ad11335d7de) [[vm,dyn_modules] Convert function type args to instance type args when allocating an object in constructor tear-off](https://dart.googlesource.com/sdk.git/+/c006202dc6d314d9f7d035cef2c15ad11335d7de) by Alexander Markov · 31 hours ago [16cde58](https://dart.googlesource.com/sdk.git/+/16cde58fa2ba7b04fce7f0c0c532216540698797) [Version 3.9.0-192.0.dev](https://dart.googlesource.com/sdk.git/+/16cde58fa2ba7b04fce7f0c0c532216540698797) by Dart CI · 34 hours ago [3.9.0-192.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-192.0.dev) [d004127](https://dart.googlesource.com/sdk.git/+/d0041273c5800d08167231e3427e2344346e7796) [[cfe] Implement getter-setter-error for extension types](https://dart.googlesource.com/sdk.git/+/d0041273c5800d08167231e3427e2344346e7796) by Chloe Stefantsova · 34 hours ago [fd9960f](https://dart.googlesource.com/sdk.git/+/fd9960f3247980084f4e097d9453c952cc8475e5) [[cfe] Create declarations directly in _PropertyPreBuilder](https://dart.googlesource.com/sdk.git/+/fd9960f3247980084f4e097d9453c952cc8475e5) by Johnni Winther · 36 hours ago [1117dce](https://dart.googlesource.com/sdk.git/+/1117dce94d05eac5d9606e9d0f62e9ceb7c2e69e) [[model] Mark erroneously initialized optional parameters as such](https://dart.googlesource.com/sdk.git/+/1117dce94d05eac5d9606e9d0f62e9ceb7c2e69e) by Chloe Stefantsova · 2 days ago [c21beef](https://dart.googlesource.com/sdk.git/+/c21beef54e1fcaf6159aee2367a2fb995eaddf97) [remove unused import](https://dart.googlesource.com/sdk.git/+/c21beef54e1fcaf6159aee2367a2fb995eaddf97) by Jake Macdonald · 2 days ago [5d2e1ef](https://dart.googlesource.com/sdk.git/+/5d2e1ef0dcd32b143aac8b15d49250d84bd5abeb) [Version 3.9.0-191.0.dev](https://dart.googlesource.com/sdk.git/+/5d2e1ef0dcd32b143aac8b15d49250d84bd5abeb) by Dart CI · 2 days ago [3.9.0-191.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-191.0.dev) [ce6e968](https://dart.googlesource.com/sdk.git/+/ce6e9685dff28d412c05bf66f925395100fdd9ed) [Bump the github-actions group with 2 updates](https://dart.googlesource.com/sdk.git/+/ce6e9685dff28d412c05bf66f925395100fdd9ed) by dependabot[bot] · 2 days ago [745b0c7](https://dart.googlesource.com/sdk.git/+/745b0c732820a45fc3a097c640c4ac60b3ef51d6) [Version 3.9.0-190.0.dev](https://dart.googlesource.com/sdk.git/+/745b0c732820a45fc3a097c640c4ac60b3ef51d6) by Dart CI · 4 days ago [3.9.0-190.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-190.0.dev) [c349670](https://dart.googlesource.com/sdk.git/+/c3496701e4ad0f8ec26050982aab860d25bbe8f3) [Roll Fuchsia SDK from 28.20250519.5.1 to 28.20250528.4.1](https://dart.googlesource.com/sdk.git/+/c3496701e4ad0f8ec26050982aab860d25bbe8f3) by DEPS Autoroller · 4 days ago [a14c305](https://dart.googlesource.com/sdk.git/+/a14c3059e957c7085a762bb84d92c7df52811135) [Roll Fuchsia Test Scripts from L6SMsr0eTyQlN6KR4... to DG11ez0PRGu8loi2m...](https://dart.googlesource.com/sdk.git/+/a14c3059e957c7085a762bb84d92c7df52811135) by DEPS Autoroller · 4 days ago [3f2a696](https://dart.googlesource.com/sdk.git/+/3f2a6963fb1f3cd31cb797e8f04e335a08e75ca9) [[dart2js] Improve algorithm for condition targets](https://dart.googlesource.com/sdk.git/+/3f2a6963fb1f3cd31cb797e8f04e335a08e75ca9) by Stephen Adams · 4 days ago [bafa801](https://dart.googlesource.com/sdk.git/+/bafa80177f1a9a2cafc2b7a028595b5cfeb6229d) [Version 3.9.0-189.0.dev](https://dart.googlesource.com/sdk.git/+/bafa80177f1a9a2cafc2b7a028595b5cfeb6229d) by Dart CI · 4 days ago [3.9.0-189.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-189.0.dev) [d34f769](https://dart.googlesource.com/sdk.git/+/d34f769deb34ab5dbda0a03f17c15d7c6f18f88e) [Roll gn from ebc8f16ca7b0 to afd24ed11bc5](https://dart.googlesource.com/sdk.git/+/d34f769deb34ab5dbda0a03f17c15d7c6f18f88e) by DEPS Autoroller · 4 days ago [85ccbe6](https://dart.googlesource.com/sdk.git/+/85ccbe6d8d13c6e036446f9d9c1664e639044a41) [[dart2js] `late final` initialized instance field getters are idempotent](https://dart.googlesource.com/sdk.git/+/85ccbe6d8d13c6e036446f9d9c1664e639044a41) by Stephen Adams · 4 days ago [28fc6346](https://dart.googlesource.com/sdk.git/+/28fc6346eb4f71674441afac45797516d627feb8) [analyzer: Move RuleContext and RuleContextUnit to public API](https://dart.googlesource.com/sdk.git/+/28fc6346eb4f71674441afac45797516d627feb8) by Sam Rawlins · 4 days ago [2c0fad2](https://dart.googlesource.com/sdk.git/+/2c0fad24ffc13cc3e573410f1015676fafd565ae) [Normalize the diagnostic pages](https://dart.googlesource.com/sdk.git/+/2c0fad24ffc13cc3e573410f1015676fafd565ae) by Brian Wilkerson · 4 days ago [b45d25b](https://dart.googlesource.com/sdk.git/+/b45d25ba1e1726f316d5d753e29d6551267a0776) [Elements. Print MethodElementImpl references in text expectations.](https://dart.googlesource.com/sdk.git/+/b45d25ba1e1726f316d5d753e29d6551267a0776) by Konstantin Shcheglov · 4 days ago [63aa736](https://dart.googlesource.com/sdk.git/+/63aa736da20821f23fcadfe9dbafe49705695f64) [Elements. Add reference to MethodElementImpl, write it.](https://dart.googlesource.com/sdk.git/+/63aa736da20821f23fcadfe9dbafe49705695f64) by Konstantin Shcheglov · 4 days ago [9507d7a](https://dart.googlesource.com/sdk.git/+/9507d7a05ecf218d4e50700cb634edace930db01) [Version 3.9.0-188.0.dev](https://dart.googlesource.com/sdk.git/+/9507d7a05ecf218d4e50700cb634edace930db01) by Dart CI · 4 days ago [3.9.0-188.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-188.0.dev) [55a2089](https://dart.googlesource.com/sdk.git/+/55a2089034e757c339a5bf01845505758e4f78b0) [Add a test for hasPublishedDocs](https://dart.googlesource.com/sdk.git/+/55a2089034e757c339a5bf01845505758e4f78b0) by Brian Wilkerson · 4 days ago [2b59598](https://dart.googlesource.com/sdk.git/+/2b59598defdbbcc7e06d507ad74cf225c615d6b5) [Display message scheduler information on the diagnostic pages](https://dart.googlesource.com/sdk.git/+/2b59598defdbbcc7e06d507ad74cf225c615d6b5) by Brian Wilkerson · 4 days ago [d49cd3c](https://dart.googlesource.com/sdk.git/+/d49cd3c552afa222ed1cbbee85a8d50d725902e7) [[dart2js] Track, rather than compute, `isCallOnInterceptor`](https://dart.googlesource.com/sdk.git/+/d49cd3c552afa222ed1cbbee85a8d50d725902e7) by Stephen Adams · 4 days ago [74f74d7](https://dart.googlesource.com/sdk.git/+/74f74d71578b01495cf40a6f5d7b561787806d92) [[analysis_server] Dot shorthands: Document highlights tests.](https://dart.googlesource.com/sdk.git/+/74f74d71578b01495cf40a6f5d7b561787806d92) by Kallen Tu · 4 days ago [e724547](https://dart.googlesource.com/sdk.git/+/e7245478926551fac327ac9abbc01aad53eb74a8) [Elements. Deprecate Annotatable.metadata2, use 'metadata' instead.](https://dart.googlesource.com/sdk.git/+/e7245478926551fac327ac9abbc01aad53eb74a8) by Konstantin Shcheglov · 4 days ago [8f9cab4](https://dart.googlesource.com/sdk.git/+/8f9cab444059fa84df8eed6eb61c7727c7b70f92) [[analysis_server] Dot shorthands: Go to type definition tests.](https://dart.googlesource.com/sdk.git/+/8f9cab444059fa84df8eed6eb61c7727c7b70f92) by Kallen Tu · 4 days ago [f18bd99](https://dart.googlesource.com/sdk.git/+/f18bd99230b56cbe77e3e7742908c895c48ec93f) [[DAS] Fixes comment references for enum constants](https://dart.googlesource.com/sdk.git/+/f18bd99230b56cbe77e3e7742908c895c48ec93f) by FMorschel · 4 days ago [5a6d0cf](https://dart.googlesource.com/sdk.git/+/5a6d0cf4feb4768c0b4dae34df55dc8762d01cf5) [Version 3.9.0-187.0.dev](https://dart.googlesource.com/sdk.git/+/5a6d0cf4feb4768c0b4dae34df55dc8762d01cf5) by Dart CI · 4 days ago [3.9.0-187.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-187.0.dev) [c98a91f](https://dart.googlesource.com/sdk.git/+/c98a91f182d813b5b4a141bfa0b1093f0f7eb435) [Elements. Rename Element2Extension.metadata to metadataAnnotations.](https://dart.googlesource.com/sdk.git/+/c98a91f182d813b5b4a141bfa0b1093f0f7eb435) by Konstantin Shcheglov · 4 days ago [d2252b1](https://dart.googlesource.com/sdk.git/+/d2252b1fd6c95d4a7a2a748c3ccc14a65082d20a) [[dyn_modules] Add option to dump detailed dynamic interface](https://dart.googlesource.com/sdk.git/+/d2252b1fd6c95d4a7a2a748c3ccc14a65082d20a) by Alexander Markov · 4 days ago [70dd226](https://dart.googlesource.com/sdk.git/+/70dd22696b09ac21b5c09774434b496eda071097) [Version 3.9.0-186.0.dev](https://dart.googlesource.com/sdk.git/+/70dd22696b09ac21b5c09774434b496eda071097) by Dart CI · 4 days ago [3.9.0-186.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-186.0.dev) [804c6bb](https://dart.googlesource.com/sdk.git/+/804c6bbd84b03d79bb71ec94e3c93b5afeb6a107) [[test_runner] Remove duplicate "allowed values" help, use package:args's allowed value help feature](https://dart.googlesource.com/sdk.git/+/804c6bbd84b03d79bb71ec94e3c93b5afeb6a107) by Ömer Ağacan · 5 days ago [111af5a](https://dart.googlesource.com/sdk.git/+/111af5a62b5d3b851b2dc561bea001c1f32d63c0) [Version 3.9.0-185.0.dev](https://dart.googlesource.com/sdk.git/+/111af5a62b5d3b851b2dc561bea001c1f32d63c0) by Dart CI · 5 days ago [3.9.0-185.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-185.0.dev) [5dec261](https://dart.googlesource.com/sdk.git/+/5dec261948add3c1cc720f0f47c7d7b499298201) [Fix test group name for sound flow analysis.](https://dart.googlesource.com/sdk.git/+/5dec261948add3c1cc720f0f47c7d7b499298201) by Paul Berry · 5 days ago [fa9712b](https://dart.googlesource.com/sdk.git/+/fa9712b13722d948852f172d5e29df6ba3bd3fb7) [Version 3.9.0-184.0.dev](https://dart.googlesource.com/sdk.git/+/fa9712b13722d948852f172d5e29df6ba3bd3fb7) by Dart CI · 5 days ago [3.9.0-184.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-184.0.dev) [0467dfc](https://dart.googlesource.com/sdk.git/+/0467dfc43458e03624d93dba35e819a462f2def9) [Bump ai to 2a5eb30492c4231624ae954e93aa1491e4aca84f](https://dart.googlesource.com/sdk.git/+/0467dfc43458e03624d93dba35e819a462f2def9) by Jake Macdonald · 5 days ago [605170d](https://dart.googlesource.com/sdk.git/+/605170dae33d0de700880ee1af9386a1b7c7951b) [Version 3.9.0-183.0.dev](https://dart.googlesource.com/sdk.git/+/605170dae33d0de700880ee1af9386a1b7c7951b) by Dart CI · 5 days ago [3.9.0-183.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-183.0.dev) [09dc185](https://dart.googlesource.com/sdk.git/+/09dc185bd53ac7858222d23a2b3945afa936814e) [Elements. Use combineSignatureTypes() for inheritance inference.](https://dart.googlesource.com/sdk.git/+/09dc185bd53ac7858222d23a2b3945afa936814e) by Konstantin Shcheglov · 5 days ago [009a619](https://dart.googlesource.com/sdk.git/+/009a6194b35be6cb67d8d714fefc8ad1757639ff) [[analysis_server] Dot shorthands: Call hierarchy changes and tests.](https://dart.googlesource.com/sdk.git/+/009a6194b35be6cb67d8d714fefc8ad1757639ff) by Kallen Tu · 5 days ago [b999c90](https://dart.googlesource.com/sdk.git/+/b999c900f37abab66c04cabd9cd67560d8d5bfef) [Version 3.9.0-182.0.dev](https://dart.googlesource.com/sdk.git/+/b999c900f37abab66c04cabd9cd67560d8d5bfef) by Dart CI · 5 days ago [3.9.0-182.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-182.0.dev) [b980788](https://dart.googlesource.com/sdk.git/+/b980788bf9ab4c3bf2844b8ca3bf2d1725934b0e) [[test_runner] Use 'line' progress indicator by default when stdout is not a terminal](https://dart.googlesource.com/sdk.git/+/b980788bf9ab4c3bf2844b8ca3bf2d1725934b0e) by Ömer Ağacan · 5 days ago [41ac971](https://dart.googlesource.com/sdk.git/+/41ac971d8a35ad3745e32d8cf423f261129f5df9) [analyzer: rename Lint*Context classes](https://dart.googlesource.com/sdk.git/+/41ac971d8a35ad3745e32d8cf423f261129f5df9) by Sam Rawlins · 5 days ago [e4cac29](https://dart.googlesource.com/sdk.git/+/e4cac2901a65ee69a3b52fde107312bca1f5c61d) [Bump ai to cf7d67f1e653cc9d8988ff0dc549eb7c357c3ef9](https://dart.googlesource.com/sdk.git/+/e4cac2901a65ee69a3b52fde107312bca1f5c61d) by Jake Macdonald · 5 days ago [b085dd5](https://dart.googlesource.com/sdk.git/+/b085dd53f405c30b90f47b619278f5596b18ac3d) [analyzer: Simplify some FileAnalysis usage](https://dart.googlesource.com/sdk.git/+/b085dd53f405c30b90f47b619278f5596b18ac3d) by Sam Rawlins · 5 days ago [1d26804](https://dart.googlesource.com/sdk.git/+/1d268045c0ed151be4c89ba68f2dc3a47b8c1cae) [[dart2wasm] Fix param info lookup to match signature lookup logic.](https://dart.googlesource.com/sdk.git/+/1d268045c0ed151be4c89ba68f2dc3a47b8c1cae) by Nate Biggs · 5 days ago [31607cc](https://dart.googlesource.com/sdk.git/+/31607cc56a0e09b60e614f8160899b723aa16915) [Elements. Write more ElementImpl as references, not as fragments.](https://dart.googlesource.com/sdk.git/+/31607cc56a0e09b60e614f8160899b723aa16915) by Konstantin Shcheglov · 5 days ago [23c6ee8](https://dart.googlesource.com/sdk.git/+/23c6ee82c84b66f691f375bfa2582df889c668c7) [Version 3.9.0-181.0.dev](https://dart.googlesource.com/sdk.git/+/23c6ee82c84b66f691f375bfa2582df889c668c7) by Dart CI · 6 days ago [3.9.0-181.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-181.0.dev) [b414df2](https://dart.googlesource.com/sdk.git/+/b414df224a0c41f820103b33a9f0e48ecca9fd5f) [[DEPS] Update web engines](https://dart.googlesource.com/sdk.git/+/b414df224a0c41f820103b33a9f0e48ecca9fd5f) by Nicholas Shahan · 6 days ago [632ae99](https://dart.googlesource.com/sdk.git/+/632ae99037de7867351917ba299e983531860e34) [Version 3.9.0-180.0.dev](https://dart.googlesource.com/sdk.git/+/632ae99037de7867351917ba299e983531860e34) by Dart CI · 6 days ago [3.9.0-180.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-180.0.dev) [25d5721](https://dart.googlesource.com/sdk.git/+/25d57216e9a5846da7100a35af2527f6de8e032d) [Bump tools to a0dda7e50bcd99fd3be8512cf546d872ba39e046](https://dart.googlesource.com/sdk.git/+/25d57216e9a5846da7100a35af2527f6de8e032d) by Devon Carew · 6 days ago [560bb8e](https://dart.googlesource.com/sdk.git/+/560bb8e0aab5e1934aec2461a03f66f3b5d55eca) [[analysis_server] Dot shorthands: Go to definition tests.](https://dart.googlesource.com/sdk.git/+/560bb8e0aab5e1934aec2461a03f66f3b5d55eca) by Kallen Tu · 6 days ago [676df8b](https://dart.googlesource.com/sdk.git/+/676df8b25813bd13a9f9aecd1cb35c66a7e2741f) [Elements. Remove PrefixElementImpl.](https://dart.googlesource.com/sdk.git/+/676df8b25813bd13a9f9aecd1cb35c66a7e2741f) by Konstantin Shcheglov · 6 days ago [eba91c50](https://dart.googlesource.com/sdk.git/+/eba91c5045d612a6cbca7b5ae4e62388a07980e4) [analyzer: Move RuleState into the public API](https://dart.googlesource.com/sdk.git/+/eba91c5045d612a6cbca7b5ae4e62388a07980e4) by Sam Rawlins · 6 days ago [25b54e2](https://dart.googlesource.com/sdk.git/+/25b54e2d82cc0d21eb2344bfa446ce4cda301edb) [Version 3.9.0-179.0.dev](https://dart.googlesource.com/sdk.git/+/25b54e2d82cc0d21eb2344bfa446ce4cda301edb) by Dart CI · 6 days ago [3.9.0-179.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-179.0.dev) [34c5794](https://dart.googlesource.com/sdk.git/+/34c5794fffcf87068990b87bee03cc05783f6a76) [Elements. Make FragmentOrMember implement Fragment.](https://dart.googlesource.com/sdk.git/+/34c5794fffcf87068990b87bee03cc05783f6a76) by Konstantin Shcheglov · 6 days ago [9d22935](https://dart.googlesource.com/sdk.git/+/9d229350636b942f068ea38adb59b213499fc541) [Elements. Rename ElementOrMember to FragmentOrMember.](https://dart.googlesource.com/sdk.git/+/9d229350636b942f068ea38adb59b213499fc541) by Konstantin Shcheglov · 6 days ago [b117e10](https://dart.googlesource.com/sdk.git/+/b117e10703df065c13c612d6cf3e6132c2e6e39e) [Elements. Remove InterfaceFragmentImpl.instantiateImpl()](https://dart.googlesource.com/sdk.git/+/b117e10703df065c13c612d6cf3e6132c2e6e39e) by Konstantin Shcheglov · 6 days ago [5af6310](https://dart.googlesource.com/sdk.git/+/5af6310f9c8faa9d4123a615e3aba4f6e2b4b9e4) [Elements. Use named formal parameters for FragmentImpl constructors.](https://dart.googlesource.com/sdk.git/+/5af6310f9c8faa9d4123a615e3aba4f6e2b4b9e4) by Konstantin Shcheglov · 6 days ago [cde11c1](https://dart.googlesource.com/sdk.git/+/cde11c1005c6711af8959f00d205c16caafec396) [CQ. Make a couple of methods return void, remove unawaited() for them.](https://dart.googlesource.com/sdk.git/+/cde11c1005c6711af8959f00d205c16caafec396) by Konstantin Shcheglov · 6 days ago [0787d1e](https://dart.googlesource.com/sdk.git/+/0787d1eeece46a2d5f139e0a1390040735e9b7e0) [Use a more structured response type for `ConnectedApp.getVmServices` API](https://dart.googlesource.com/sdk.git/+/0787d1eeece46a2d5f139e0a1390040735e9b7e0) by Kenzie Davisson · 6 days ago [ebef427](https://dart.googlesource.com/sdk.git/+/ebef427bc563a052f72b536a452d660a852a2371) [[vm] Remove dead VerifyCanonicalVisitor.](https://dart.googlesource.com/sdk.git/+/ebef427bc563a052f72b536a452d660a852a2371) by Ryan Macnak · 6 days ago [2ecc1ee](https://dart.googlesource.com/sdk.git/+/2ecc1ee8e8b951caf595be17d0e34b090634260a) [Close open file descriptors that are not needed during process spawn or exec.](https://dart.googlesource.com/sdk.git/+/2ecc1ee8e8b951caf595be17d0e34b090634260a) by asiva · 6 days ago [3959470](https://dart.googlesource.com/sdk.git/+/395947051e064efb75f6b914edfa66b95252ff33) [[linter] Improve correction message for discarded_futures.](https://dart.googlesource.com/sdk.git/+/395947051e064efb75f6b914edfa66b95252ff33) by Paul Berry · 6 days ago [1806e4c](https://dart.googlesource.com/sdk.git/+/1806e4ce65701d3165a405d90f7d32b976bac072) [[ddc] Use direct cast methods for primitive casts](https://dart.googlesource.com/sdk.git/+/1806e4ce65701d3165a405d90f7d32b976bac072) by Nicholas Shahan · 6 days ago [2b5b551](https://dart.googlesource.com/sdk.git/+/2b5b551cfbcea199714d0b46c5edd4c2cd52e644) [Fine. Record InstanceElement.fields/getters/setters access.](https://dart.googlesource.com/sdk.git/+/2b5b551cfbcea199714d0b46c5edd4c2cd52e644) by Konstantin Shcheglov · 6 days ago [3033393](https://dart.googlesource.com/sdk.git/+/3033393fe6f2f99c212ed3b6b47e1d34ba4fb1e2) [Bump ai to 47fa2fcf476a905b316282d9351e4ed063755ead](https://dart.googlesource.com/sdk.git/+/3033393fe6f2f99c212ed3b6b47e1d34ba4fb1e2) by Jake Macdonald · 6 days ago [bfc8faa](https://dart.googlesource.com/sdk.git/+/bfc8faabb8278bbc689e1f78b1c26e5962776113) [CodeGen. Document GenerateNodeProperty. #2](https://dart.googlesource.com/sdk.git/+/bfc8faabb8278bbc689e1f78b1c26e5962776113) by Konstantin Shcheglov · 6 days ago [6b29fb0](https://dart.googlesource.com/sdk.git/+/6b29fb01e6492677891922388ded1ac631f02588) [Version 3.9.0-178.0.dev](https://dart.googlesource.com/sdk.git/+/6b29fb01e6492677891922388ded1ac631f02588) by Dart CI · 6 days ago [3.9.0-178.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-178.0.dev) [525b67a](https://dart.googlesource.com/sdk.git/+/525b67a9fe6e6c04fd343af1ff4cf647356b4b6e) [Enable discarded_futures lint in analyzer and _fe_analyzer_shared.](https://dart.googlesource.com/sdk.git/+/525b67a9fe6e6c04fd343af1ff4cf647356b4b6e) by Paul Berry · 6 days ago [53ecbfd](https://dart.googlesource.com/sdk.git/+/53ecbfd9991af13b134240d621c62294cdf9d919) [[dyn_modules] Do not add dart:core as callable by default](https://dart.googlesource.com/sdk.git/+/53ecbfd9991af13b134240d621c62294cdf9d919) by Alexander Markov · 6 days ago [8023313](https://dart.googlesource.com/sdk.git/+/802331361fb7358bbf9379450e40207030170af6) [[dartfuzz] Add missing build target.](https://dart.googlesource.com/sdk.git/+/802331361fb7358bbf9379450e40207030170af6) by Ryan Macnak · 6 days ago [b061f91](https://dart.googlesource.com/sdk.git/+/b061f911f9af5fa585fdedff2cf46c77089b8d43) [[vm] Fix dynamic module build.](https://dart.googlesource.com/sdk.git/+/b061f911f9af5fa585fdedff2cf46c77089b8d43) by Ryan Macnak · 6 days ago [f214457](https://dart.googlesource.com/sdk.git/+/f21445710b4efd6da8740f6af6b5251be086490d) [[cfe] Add Fragment.uriOffset](https://dart.googlesource.com/sdk.git/+/f21445710b4efd6da8740f6af6b5251be086490d) by Johnni Winther · 6 days ago [b3a04fa](https://dart.googlesource.com/sdk.git/+/b3a04fac5c22bf4732e859930a022014abfcdbc6) [Version 3.9.0-177.0.dev](https://dart.googlesource.com/sdk.git/+/b3a04fac5c22bf4732e859930a022014abfcdbc6) by Dart CI · 6 days ago [3.9.0-177.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-177.0.dev) [57b8c4b](https://dart.googlesource.com/sdk.git/+/57b8c4b93ec2cc2a8e71774aba7bfbb252821109) [Update changelog on main with 3.8.1 entries](https://dart.googlesource.com/sdk.git/+/57b8c4b93ec2cc2a8e71774aba7bfbb252821109) by Ivan Inozemtsev · 6 days ago [b184889](https://dart.googlesource.com/sdk.git/+/b1848895b8069772ce64199ff9ce73b81c07ed66) [[model] Add makAsErroneous to ConstructorDeclaration and encodings](https://dart.googlesource.com/sdk.git/+/b1848895b8069772ce64199ff9ce73b81c07ed66) by Chloe Stefantsova · 6 days ago [aa0f0e1](https://dart.googlesource.com/sdk.git/+/aa0f0e1acaf2e4a9ad1ef02d57956301881546e1) [[cfe] Remove MemberBuilder.isConflictingSetter](https://dart.googlesource.com/sdk.git/+/aa0f0e1acaf2e4a9ad1ef02d57956301881546e1) by Johnni Winther · 7 days ago [0045c0e](https://dart.googlesource.com/sdk.git/+/0045c0e1c6837ee636af4f9495ef5ed570c3a4e3) [[dart2wasm] Remove FunctionNode dependency from ClosureDynamicEntryGenerator](https://dart.googlesource.com/sdk.git/+/0045c0e1c6837ee636af4f9495ef5ed570c3a4e3) by Ömer Ağacan · 7 days ago [2fc0c8b](https://dart.googlesource.com/sdk.git/+/2fc0c8bf0824ee65dcb03cb7591649189a07c823) [[dart2wasm] Some refactorings of the compiler](https://dart.googlesource.com/sdk.git/+/2fc0c8bf0824ee65dcb03cb7591649189a07c823) by Martin Kustermann · 7 days ago [adb179c](https://dart.googlesource.com/sdk.git/+/adb179ced0bebde1e15f34bf5c212e584a555144) [Version 3.9.0-176.0.dev](https://dart.googlesource.com/sdk.git/+/adb179ced0bebde1e15f34bf5c212e584a555144) by Dart CI · 7 days ago [3.9.0-176.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-176.0.dev) [ac2fc57](https://dart.googlesource.com/sdk.git/+/ac2fc57446abe56b6f94f9940c355c871385678e) [[cfe] Combine getter/setter and final field/setter into one property builder](https://dart.googlesource.com/sdk.git/+/ac2fc57446abe56b6f94f9940c355c871385678e) by Johnni Winther · 7 days ago [b5e12ec](https://dart.googlesource.com/sdk.git/+/b5e12ecafffeb27332ba761605da0e26d247fff0) [Replace use of NodeLocator2 in CorrectionProducer](https://dart.googlesource.com/sdk.git/+/b5e12ecafffeb27332ba761605da0e26d247fff0) by Brian Wilkerson · 7 days ago [4bb760d](https://dart.googlesource.com/sdk.git/+/4bb760d8375ea25d0516e7b8719c8ee4c4b71ad3) [Version 3.9.0-175.0.dev](https://dart.googlesource.com/sdk.git/+/4bb760d8375ea25d0516e7b8719c8ee4c4b71ad3) by Dart CI · 7 days ago [3.9.0-175.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-175.0.dev) [797b076](https://dart.googlesource.com/sdk.git/+/797b076edb212d1eb26b10051f0c51c603523497) [Check for visisbility only once when adding completions for element members.](https://dart.googlesource.com/sdk.git/+/797b076edb212d1eb26b10051f0c51c603523497) by Keerti Parthasarathy · 7 days ago [19992d8](https://dart.googlesource.com/sdk.git/+/19992d86c0997288f02133716c1ab94371759fc6) [Version 3.9.0-174.0.dev](https://dart.googlesource.com/sdk.git/+/19992d86c0997288f02133716c1ab94371759fc6) by Dart CI · 7 days ago [3.9.0-174.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-174.0.dev) [a4e0a0b](https://dart.googlesource.com/sdk.git/+/a4e0a0b3f8fcc362b895a801ed9125172fcff190) [[build] Pass -Zxz to dh_builddeb instead of dpkg-buildpackage.](https://dart.googlesource.com/sdk.git/+/a4e0a0b3f8fcc362b895a801ed9125172fcff190) by Ryan Macnak · 7 days ago [323b247](https://dart.googlesource.com/sdk.git/+/323b247ba96fdc4843645d7e13e34b27d00b0831) [[build] Explicitly build the Debian package using xz compression.](https://dart.googlesource.com/sdk.git/+/323b247ba96fdc4843645d7e13e34b27d00b0831) by Ryan Macnak · 7 days ago [93ddc95](https://dart.googlesource.com/sdk.git/+/93ddc95051548f11f7ae1c7733789b390188f987) [Bump dartdoc to 8e6a95c4aba8def4ef01ccc600b3a3cfb8f3cb9e](https://dart.googlesource.com/sdk.git/+/93ddc95051548f11f7ae1c7733789b390188f987) by Devon Carew · 7 days ago [786b6c5](https://dart.googlesource.com/sdk.git/+/786b6c5612860740105a09d536f6801ff59f74d9) [[dartfuzz] Extend VM flag fuzzing to dartfuzz and iso-stress.](https://dart.googlesource.com/sdk.git/+/786b6c5612860740105a09d536f6801ff59f74d9) by Ryan Macnak · 7 days ago [f8f2227](https://dart.googlesource.com/sdk.git/+/f8f22279f120f4fe6577561e183cd4a5f2888ceb) [Version 3.9.0-173.0.dev](https://dart.googlesource.com/sdk.git/+/f8f22279f120f4fe6577561e183cd4a5f2888ceb) by Dart CI · 7 days ago [3.9.0-173.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.9.0-173.0.dev) [012d84a](https://dart.googlesource.com/sdk.git/+/012d84a821859a29bc63239cbb6f171db8f578ea) [Fine. Record requesting the whole interface.](https://dart.googlesource.com/sdk.git/+/012d84a821859a29bc63239cbb6f171db8f578ea) by Konstantin Shcheglov · 7 days ago [e2fdf18](https://dart.googlesource.com/sdk.git/+/e2fdf18b66ba7da09f60f9d91966a86d7e38f827) [[dart2js] Refine types based on test with late sentinel](https://dart.googlesource.com/sdk.git/+/e2fdf18b66ba7da09f60f9d91966a86d7e38f827) by Stephen Adams · 7 days ago [8955223](https://dart.googlesource.com/sdk.git/+/89552236ffb3c60bd2bdcc8a1c68d3d5c441214f) [[analyzer] Dot shorthands: Infer type parameters in constructor tearoffs.](https://dart.googlesource.com/sdk.git/+/89552236ffb3c60bd2bdcc8a1c68d3d5c441214f) by Kallen Tu · 7 days ago [785b38e](https://dart.googlesource.com/sdk.git/+/785b38ed5b38b5e822f49f5c1d5a0367e3d3f7fa) [Convert remove-dead-code to use nodeCovering](https://dart.googlesource.com/sdk.git/+/785b38ed5b38b5e822f49f5c1d5a0367e3d3f7fa) by Brian Wilkerson · 7 days ago [b916392](https://dart.googlesource.com/sdk.git/+/b9163920083e1415bf925aab7bf57dc99073f50a) [[vm] Move handle check after barrier in CompileFunction runtime entry.](https://dart.googlesource.com/sdk.git/+/b9163920083e1415bf925aab7bf57dc99073f50a) by Ryan Macnak · 7 days ago [18aa7d3](https://dart.googlesource.com/sdk.git/+/18aa7d3678fd9fa8ffd4e2e8cdf23582a3c14474) [[vm] Refactor runtime entries.](https://dart.googlesource.com/sdk.git/+/18aa7d3678fd9fa8ffd4e2e8cdf23582a3c14474) by Ryan Macnak · 7 days ago [d2c0f0a](https://dart.googlesource.com/sdk.git/+/d2c0f0ae16383564d0307dfad579c2c9e0a2d82e) [[analysis_server] Support folding try/catch/finally blocks](https://dart.googlesource.com/sdk.git/+/d2c0f0ae16383564d0307dfad579c2c9e0a2d82e) by Danny Tuppeny · 7 days ago [33daa43](https://dart.googlesource.com/sdk.git/+/33daa43c861a800f0cb80a95506a1ac4127ffc64) [CodeGen. Document GenerateNodeProperty.](https://dart.googlesource.com/sdk.git/+/33daa43c861a800f0cb80a95506a1ac4127ffc64) by Konstantin Shcheglov · 7 days ago [77dd4fb3](https://dart.googlesource.com/sdk.git/+/77dd4fb3eaf086e393e73f126bd9bfe29f08d047) [Fine. Remove library self-dependency from 'instances'.](https://dart.googlesource.com/sdk.git/+/77dd4fb3eaf086e393e73f126bd9bfe29f08d047) by Konstantin Shcheglov · 7 days ago [4a64532](https://dart.googlesource.com/sdk.git/+/4a64532ace049bdf6559a0330ff693326e124acc) [Fine. Match type parameters of InstanceItem(s).](https://dart.googlesource.com/sdk.git/+/4a64532ace049bdf6559a0330ff693326e124acc) by Konstantin Shcheglov · 7 days ago [5047e68](https://dart.googlesource.com/sdk.git/+/5047e6895fbc6b0e25ea07e45e6438ff15f8c476) [[dds/dap] Handle parsing stack frames that contain dots in paths](https://dart.googlesource.com/sdk.git/+/5047e6895fbc6b0e25ea07e45e6438ff15f8c476) by Danny Tuppeny · 7 days ago [d828c36](https://dart.googlesource.com/sdk.git/+/d828c36cec4da9e39a862ea786debb83eeab4320) [Add a `dart mcp-server` command per go/dart-mcp-server-release-plan.](https://dart.googlesource.com/sdk.git/+/d828c36cec4da9e39a862ea786debb83eeab4320) by Jake Macdonald · 7 days ago [f3a4e5b](https://dart.googlesource.com/sdk.git/+/f3a4e5bc548fa6d950600418b44b01421d6b73ad) [Fine. Record InstanceElement.methods access.](https://dart.googlesource.com/sdk.git/+/f3a4e5bc548fa6d950600418b44b01421d6b73ad) by Konstantin Shcheglov · 7 days ago [03515b4](https://dart.googlesource.com/sdk.git/+/03515b472e883f71e8a730da454ed5dc4e610956) [[analyzer] Dot shorthands: Update indexing.](https://dart.googlesource.com/sdk.git/+/03515b472e883f71e8a730da454ed5dc4e610956) by Kallen Tu · 7 days ago [15f49c9d](https://dart.googlesource.com/sdk.git/+/15f49c9da0f62c840c4425254870d06db69eba58) [[deps] rev tools](https://dart.googlesource.com/sdk.git/+/15f49c9da0f62c840c4425254870d06db69eba58) by Danny Tuppeny · 7 days ago [e3fe1c3](https://dart.googlesource.com/sdk.git/+/e3fe1c36f376358e012ee9b09258dab6210a99ce) [Issue 60791. Don't add elements without names to exported references.](https://dart.googlesource.com/sdk.git/+/e3fe1c36f376358e012ee9b09258dab6210a99ce) by Konstantin Shcheglov · 7 days ago [6b53073](https://dart.googlesource.com/sdk.git/+/6b53073eae118baec4fd5b9c9b6e8cf743df1587) [Reland "[vm, gen_snapshot] Add app-aot-macho-dylib option for AOT snapshots."](https://dart.googlesource.com/sdk.git/+/6b53073eae118baec4fd5b9c9b6e8cf743df1587) by Tess Strickland · 7 days ago [38ea3a8](https://dart.googlesource.com/sdk.git/+/38ea3a8f5e930ee77a0ff407cdbbec0629d22faa) [Revert "[vm, gen_snapshot] Add app-aot-macho-dylib option for AOT snapshots."](https://dart.googlesource.com/sdk.git/+/38ea3a8f5e930ee77a0ff407cdbbec0629d22faa) by Tess Strickland · 8 days ago
QuncCccccc
pushed a commit
that referenced
this pull request
Sep 12, 2025
simular to flutter#174292 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
QuncCccccc
pushed a commit
that referenced
this pull request
Nov 4, 2025
This test passes when run locally as instructed in the README for the devicelab ``` ../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_verified_input_test ``` but fails on CI: https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20android_verified_input_test/106/overview ``` [2025-11-03 11:08:04.090018] [STDOUT] stdout: [ ] Original error: ext.flutter.driver: (-32000) Service connection disposed [2025-11-03 11:08:04.090156] [STDOUT] stdout: [ ] Original stack trace: [2025-11-03 11:08:04.090199] [STDOUT] stdout: [ ] #0 new _OutstandingRequest (package:vm_service/src/vm_service.dart:268:34) [2025-11-03 11:08:04.091572] [STDOUT] stdout: [ ] #1 VmService._call.<anonymous closure> (package:vm_service/src/vm_service.dart:1950:25) [2025-11-03 11:08:04.091647] [STDOUT] stdout: [ ] #2 VmService._call (package:vm_service/src/vm_service.dart:1962:8) [2025-11-03 11:08:04.091674] [STDOUT] stdout: [ ] flutter#3 VmService.callServiceExtension (package:vm_service/src/vm_service.dart:1901:14) [2025-11-03 11:08:04.091693] [STDOUT] stdout: [ ] flutter#4 VMServiceFlutterDriver.sendCommand (package:flutter_driver/src/driver/vmservice_driver.dart:327:12) [2025-11-03 11:08:04.091713] [STDOUT] stdout: [ ] flutter#5 FlutterDriver.requestData (package:flutter_driver/src/driver/driver.dart:573:13) [2025-11-03 11:08:04.091733] [STDOUT] stdout: [ ] flutter#6 main.<anonymous closure> (file:///opt/s/w/ir/x/w/rc/tmpv6pcbna2/flutter%20sdk/dev/integration_tests/android_verified_input/test_driver/main_test.dart:28:57) [2025-11-03 11:08:04.091750] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.091767] [STDOUT] stdout: [ ] flutter#7 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:242:9) [2025-11-03 11:08:04.091784] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092408] [STDOUT] stdout: [ ] flutter#8 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:240:7) [2025-11-03 11:08:04.092472] [STDOUT] stdout: [ ] <asynchronous suspension> [2025-11-03 11:08:04.092502] [STDOUT] stdout: [ ] flutter#9 Invoker._waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:282:9) ``` Try copying this configuration used by other tests as a speculative fix. I can't get this test to kick off in presubmit, so I suppose we will just try this. The test is marked bringup anyways so it won't block the tree if this doesn't help. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: Gray Mackall <mackall@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Will merge Part 1 first and come to solve conflict here] This PR is to create
Carousel.weightedso the size of each carousel item is based on its weight. While scrolling, item sizes are changing dynamically based on the scrolling progress.https://github.com/flutter/flutter/assets/36861262/181472b0-6f8b-48e7-b191-ab5f7c88c0c8
CC: @Piinks @goderbauer
Pre-launch Checklist
///).