Change Download Binary URL for ubuntu-20.04 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lqtmirage
reviewed
Oct 19, 2023
z3-sys/build.rs
Outdated
| @@ -198,6 +198,7 @@ fn download_z3() -> Option<String> { | |||
| .map_err(|e| e.to_string())?; | |||
| if sha256 != "PASS" { | |||
| let hash = Sha256::digest(&buf); | |||
| println!("{:?}", format!("{:x}", hash)); | |||
lqtmirage
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a current issues, we face
cargo testerror when using ubuntu-20.04 or previous versions.This problem is lead by glibc library version dependency.
In the latest z3 release, we can select appropriate binaries which are built by different glibc library.
This PR fix download URLs by judging system glibc version and switching URLs.
Also, CI for ubuntu-20.04 is added.
It seems another unit test issue for ubuntu-20.04. (CI fails)