Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation fixes - properties at chat.json (french, russian and portuguese) #937

Closed
wants to merge 8 commits into from

Conversation

GabriielEger
Copy link
Contributor

Changed empty_brain_title_intro property to chat_title_intro in french, russian and portuguese as well (english and spanish was different already).

While building the setup, when I ran yarn install, some changes were automatically made at the yarn.lock file. I hope it's not a problem.

Thank you. :)

@StanGirard
Copy link
Collaborator

Don't add the yarn.lock ;)

@GabriielEger
Copy link
Contributor Author

Hey @StanGirard! How are you? Is it alright now? Could you explain to me why there are now two properties called "empty_brain_title_intro" and "chat_title_intro" in chat.json, if only "chat_title_intro" is being used? I made changes, but on merge, the code now looks like this. Thank you. :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is still present in commit :)

What I meant is don't include your yarn.lock in the pr but don't add it to gitignore either :) just don't commit it to the pr :)

@StanGirard StanGirard closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants