Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: langfuse integration #3530

Merged
merged 2 commits into from
Dec 18, 2024
Merged

feat: langfuse integration #3530

merged 2 commits into from
Dec 18, 2024

Conversation

jacopo-chevallard
Copy link
Collaborator

Description

Small PR to integrate Langfuse tracing

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@StanGirard
Copy link
Collaborator

Should we make the callback only used when the API keys are set ?

@jacopo-chevallard
Copy link
Collaborator Author

Should we make the callback only used when the API keys are set ?

I don't that it is necessary, it is dealt with within Langfuse in principle

@jacopo-chevallard
Copy link
Collaborator Author

Should we make the callback only used when the API keys are set ?

I confirm, if any API key is missing, no trace is produced, but no error is raised either

@StanGirard StanGirard merged commit c4aae1a into main Dec 18, 2024
5 checks passed
@StanGirard StanGirard deleted the feat/langfuse_integration branch December 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants