Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Enhance example/chatbot with added instructions #3506

Merged
merged 2 commits into from
Nov 28, 2024
Merged

docs: Enhance example/chatbot with added instructions #3506

merged 2 commits into from
Nov 28, 2024

Conversation

OtaconBYF
Copy link
Contributor

@OtaconBYF OtaconBYF commented Nov 28, 2024 •
edited
Loading

Description

Instructions in README of example/chatbot is a little out-dated. Updated it to match the latest codebase.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works

Screenshots (if appropriate):

NA

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 28, 2024
@OtaconBYF OtaconBYF changed the title Enhance example/chatbot with added instructions fix: Enhance example/chatbot with added instructions Nov 28, 2024
@OtaconBYF OtaconBYF changed the title fix: Enhance example/chatbot with added instructions docs: Enhance example/chatbot with added instructions Nov 28, 2024
StanGirard
StanGirard approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@StanGirard StanGirard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks great.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 28, 2024
@StanGirard StanGirard merged commit d1d608d into QuivrHQ:main Nov 28, 2024
6 of 7 checks passed
@StanGirard StanGirard mentioned this pull request Nov 28, 2024
Merged
@OtaconBYF OtaconBYF deleted the fix/fix-example-chatbot-info branch November 28, 2024 10:59
StanGirard added a commit that referenced this pull request Nov 28, 2024
@StanGirard
chore(main): release core 0.0.25 (#3500)
1a3e03c 
🤖 I have created a release *beep* *boop*
---


##
[0.0.25](core-0.0.24...core-0.0.25)
(2024-11-28)


### Bug Fixes

* megaparse sdk with nats
([#3496](#3496))
([e68b4f4](e68b4f4))


### Documentation

* Enhance example/chatbot with added instructions
([#3506](#3506))
([d1d608d](d1d608d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanGirard StanGirard StanGirard approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OtaconBYF @StanGirard