Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(models): add more tests on service #2977

Merged
merged 1 commit into from
Aug 8, 2024
Merged

feat(models): add more tests on service #2977

merged 1 commit into from
Aug 8, 2024

Conversation

StanGirard
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Checklist before requesting a review

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented hard-to-understand areas
  • I have ideally added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Screenshots (if appropriate):

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory labels Aug 8, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 9:10am

@StanGirard StanGirard merged commit 053ce71 into release/quivr-core-0.1 Aug 8, 2024
4 checks passed
@StanGirard StanGirard deleted the feat/add-tests-for-models branch August 8, 2024 09:13
AmineDiro
AmineDiro approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@AmineDiro AmineDiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Tests 🔥

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmineDiro AmineDiro AmineDiro approved these changes

Assignees
No one assigned
Labels
area: backend Related to backend functionality or under the /backend directory lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StanGirard @AmineDiro