Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Integration of Custom Vector Stores - Pending Further Modifications for Testing #1970

Closed
wants to merge 5 commits into from

Conversation

CMobley7
Copy link

@CMobley7 CMobley7 commented Jan 4, 2024

Hello @StanGirard ,

I'm reconnecting regarding the feature request I previously submitted (#1104). Due to some delays, I was unable to commence work immediately, but I have now managed to allocate time to this initiative.

My current efforts have been focused on integrating custom vector stores into the Quivr framework. This includes an updated version of the CustomSupabaseVectorStore for improved compatibility with Langchain, along with preliminary code for CustomPGVecto_rsVectorStore, CustomPineconeVectorStore, and CustomWeaviateVectorStore vector stores, all adhering to the established format of CustomSupabaseVectorStore.

However, it's important to note that this code is yet to be tested. The nature of the changes means that further modifications are required before a meaningful test can be conducted. In light of this, I would greatly appreciate your guidance on the following:

  1. Confirmation of the desire for incorporating support for various vector stores in Quivr.
  2. Insights into which additional backend files might need updates. Currently, my changes are limited to the vector store segment (https://github.com/StanGirard/quivr/tree/main/backend/vectorstore), but I'm not entirely sure of the full scope of necessary alterations to align with the overall project architecture and your vision as the project maintainer.

For this PR, here are my contributions thus far:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on hard-to-understand areas (awaiting more insights)
  • I have not added tests yet (pending the feasibility of testing under current conditions)
  • New and existing unit tests pass locally with my changes (cannot verify due to untested code)
  • Any dependent changes have been merged (not applicable currently)

Screenshots (if appropriate): Not applicable at this stage.

I'm eagerly looking forward to your feedback and direction on how we can proceed to ensure that my work aligns effectively with the project's goals and your expectations as a maintainer.

Best regards,
CMobley7

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area: backend Related to backend functionality or under the /backend directory autorelease: pending labels Jan 4, 2024
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thanks for your contributions, we'll be closing this PR as it has gone stale. Feel free to reopen if you'd like to continue the discussion.

@github-actions github-actions bot added the Stale label Apr 5, 2024
@github-actions github-actions bot closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to backend functionality or under the /backend directory autorelease: pending size:L This PR changes 100-499 lines, ignoring generated files. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant