Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toasts (Notification Component) #163

Merged
merged 30 commits into from
May 26, 2023
Merged

Toasts (Notification Component) #163

merged 30 commits into from
May 26, 2023

Conversation

adityanandanx
Copy link
Contributor

  • Improved ui for auth pages.
  • group similar routes together with (name) file convention as per next js route groups.
  • Toasts which notify user of success, warning or error messages when doing auth / upload.

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quiver ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2023 8:55am

@adityanandanx adityanandanx requested a review from StanGirard May 26, 2023 05:14
Copy link
Contributor

@mamadoudicko mamadoudicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job on this pull request! I've spotted a couple of minor points for consideration, but let's be clear - they don't overshadow the brilliance of your work. Outstanding job!

frontend/app/components/NavBar/NavItems.tsx Outdated Show resolved Hide resolved
frontend/app/components/ui/Toast.tsx Outdated Show resolved Hide resolved
@StanGirard
Copy link
Collaborator

StanGirard commented May 26, 2023

@iMADi-ARCH last but not least ;)
image

@StanGirard StanGirard merged commit f69c64e into main May 26, 2023
@StanGirard
Copy link
Collaborator

Amazing @iMADi-ARCH ! Thanks !

StanGirard added a commit that referenced this pull request Sep 12, 2023
* feature: responsive navbar

* style: nav links hover animatiosn

* style: better Input Fields

* refactor: use form submit instead of button onclick

* feature: loading states

* feature: log out confirmation

* feature: basic toast

* feature: Toast variants

* fix: use global toast provider

* feature: use toast instead of alert for auth routes

* fix(mobile): nav menu close on route change

* fix: field dark mode

* feature: redirect when login and logout

* refactor: group auth routes

* refactor: use @/app imports

* style: use Field on /upload

* fix: forward ref

* feature: Multi toast

* feature: add toasts to /upload

* refactor: new login in auth group

* chore: quote

* chore(pnpm): removed

* feature: toasty animations

* fix: build errors and warnings

* chore: remove irrelevant comments

* fix: use unique ids for toasts

---------

Co-authored-by: Stan Girard <girard.stanislas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants