Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk restoration #661

Merged
merged 17 commits into from
Nov 19, 2024
Merged

Chunk restoration #661

merged 17 commits into from
Nov 19, 2024

Conversation

supersaiyansubtlety
Copy link
Contributor

@supersaiyansubtlety supersaiyansubtlety commented Nov 1, 2024 •
edited
Loading

Completes n/m/world/chunk/

@supersaiyansubtlety supersaiyansubtlety added t: new adds new mappings v: release targets a release version of minecraft wip this is a work in progress s: medium PRs with less than 700 lines and more than 200 labels Nov 1, 2024
@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 1, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Nov 5, 2024
@github-actions github-actions bot changed the base branch from 1.21.3 to 24w44a November 5, 2024 22:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

🚀 Target branch has been updated to 24w44a

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot added v: snapshot targets a snapshot version of minecraft outdated this pull request hasn't been updated to the latest version or has merge conflicts and removed update-base used to notify github actions that the base branch should be updated v: release targets a release version of minecraft labels Nov 5, 2024
@ix0rai ix0rai added the update-base used to notify github actions that the base branch should be updated label Nov 7, 2024
@github-actions github-actions bot changed the base branch from 24w44a to 24w45a November 7, 2024 02:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🚀 Target branch has been updated to 24w45a

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🚨 Please fix merge conflicts before this can be merged

@github-actions github-actions bot removed the update-base used to notify github actions that the base branch should be updated label Nov 7, 2024
@supersaiyansubtlety
move n/m/world/{entity/}EntityView
116a71f 
map ServerEntityView
@supersaiyansubtlety
map ServerGameEventListenerRegistry
617eb9d
@supersaiyansubtlety
complete ChunkSection, ChunkTickTracker, ProtoChunk, and UpgradeData
3f9a420
@supersaiyansubtlety
complete n/m/world/chunk:
7f0f8e9 
map ChunkLoadingTask and ChunkLoadingTasks
complete ChunkLoadingStep and ChunkLoadingSteps
complete ChunkRegion
@supersaiyansubtlety supersaiyansubtlety added reviews needed please review this PR and removed outdated this pull request hasn't been updated to the latest version or has merge conflicts wip this is a work in progress labels Nov 11, 2024
@supersaiyansubtlety supersaiyansubtlety marked this pull request as ready for review November 11, 2024 03:28
ix0rai
ix0rai requested changes Nov 17, 2024
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple minor things!

mappings/net/minecraft/world/chunk/ChunkManager.mapping Show resolved Hide resolved
simple_type_field_names.json5 Outdated Show resolved Hide resolved
@supersaiyansubtlety
re-complete n/m/world/chunk
341bd0c 
sort out some chunkX/Z vs x/z params
add simple name for Packet
@supersaiyansubtlety
fix type and missing simple type class comment
c0a486f 
correct another chunkX/Z <-> x/z param
@ix0rai ix0rai added final-comment-period is approved and will soon be merged if no issues are raised and removed reviews needed please review this PR labels Nov 18, 2024
@ix0rai ix0rai merged commit 4c1f820 into QuiltMC:24w45a Nov 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels
final-comment-period is approved and will soon be merged if no issues are raised s: medium PRs with less than 700 lines and more than 200 t: new adds new mappings v: snapshot targets a snapshot version of minecraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@supersaiyansubtlety @ix0rai