-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix+clarify ChunkTickScheduler, complete n.m.world.tick #640
Open
supersaiyansubtlety
wants to merge
4
commits into
QuiltMC:24w38a
Choose a base branch
from
supersaiyansubtlety:fix-ChunkTickScheduler
base: 24w38a
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix+clarify ChunkTickScheduler, complete n.m.world.tick #640
supersaiyansubtlety
wants to merge
4
commits into
QuiltMC:24w38a
from
supersaiyansubtlety:fix-ChunkTickScheduler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersaiyansubtlety
changed the title
fix+clarify ChunkTickScheduler memeber and related names
fix+clarify ChunkTickScheduler member and related names
Sep 17, 2024
supersaiyansubtlety
added
t: refactor
proposes a refactor
v: snapshot
targets a snapshot version of minecraft
reviews needed
please review this PR
s: tiny
PRs with less than 50 lines
labels
Sep 17, 2024
ix0rai
added
the
update-base
used to notify github actions that the base branch should be updated
label
Sep 18, 2024
🚀 Target branch has been updated to 24w38a |
github-actions
bot
removed
the
update-base
used to notify github actions that the base branch should be updated
label
Sep 18, 2024
You should take a look at the new world interface that exists now |
that does look tick-y |
probably. |
move TickPriority to tick package complete n.m.world.tick
supersaiyansubtlety
changed the title
fix+clarify ChunkTickScheduler member and related names
fix+clarify ChunkTickScheduler, complete n.m.world.tick
Sep 20, 2024
supersaiyansubtlety
added
s: small
PRs with less than 200 lines
and removed
s: tiny
PRs with less than 50 lines
labels
Sep 20, 2024
OroArmor
approved these changes
Sep 24, 2024
ix0rai
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, great refactors!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
reviews needed
please review this PR
s: small
PRs with less than 200 lines
t: refactor
proposes a refactor
v: snapshot
targets a snapshot version of minecraft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a block tick scheduler to one of my mods I was dismayed to find
ChunkTickScheduler
had three fields that seemed very similar:I was also surprised that
void disable(long time)
was the method responsible for making sure deserialized ticks actually get scheduled.I've renamed them:
I also added some javadocs clarifying how
initialTicks
works and renamed things to more consistently use "schedule".Now also completes
n.m.world.tick