-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowed the (knot) launcher to give the intended namespace #435
base: develop
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why making this public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allowing for the creation of other knots
Nvm, I don't see what past me in #435 (comment) wanted to change. I'll double-check this commit has no issues and report back on its status in a few minutes. |
Should be ready to be reviewed/merged now. Note: I'm not sure if you'd prefer to revert 89b42d3, but it will make it so that other knots can just build off the base knot, and don't have to re-implement everything. |
Adds a
getFinalNamespace()
to theQuiltLauncher
allowing the knot to provide other namespaces outside ofintermediary
to be used.Currently, the access widener's namespace preference is hardcoded as
intermediary
within theRuntimeModRemapper
, but with this change the value is now gotten from the launcher.This PR also makes several functions and classes for the knot class loaders public, allowing for the creation of other knots.