Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed the (knot) launcher to give the intended namespace #435

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

coolGi69
Copy link
Contributor

Adds a getFinalNamespace() to the QuiltLauncher allowing the knot to provide other namespaces outside of intermediary to be used.
Currently, the access widener's namespace preference is hardcoded as intermediary within the RuntimeModRemapper, but with this change the value is now gotten from the launcher.

This PR also makes several functions and classes for the knot class loaders public, allowing for the creation of other knots.

@coolGi69
Copy link
Contributor Author

coolGi69 commented May 30, 2024

I think a good idea is to move the namespace stuff that I previously moved into the game provider to the launcher. (Less duplicated code)
I'll implement that tomorrow, so don't merge this yet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why making this public?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allowing for the creation of other knots

@coolGi69
Copy link
Contributor Author

Nvm, I don't see what past me in #435 (comment) wanted to change.
Sorry for the long open time, I was on a bit of a development hiatus.

I'll double-check this commit has no issues and report back on its status in a few minutes.

@coolGi69
Copy link
Contributor Author

Should be ready to be reviewed/merged now.

Note: I'm not sure if you'd prefer to revert 89b42d3, but it will make it so that other knots can just build off the base knot, and don't have to re-implement everything.
If it is accepted, then many of the things that are made public here can be turned back to private as they no longer have to be implemented by other peoples knots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants