Issue with lost parameter connection

[rubybrowncoat]

I'm not sure how to title this issue, so please feel free to add a better name. I don't know the technical name of this kind of nesting.

As you can see from this screenshot of CFR decompiled code (which is pretty much identical to Vineflower in this case, and very similar to Procyon and they all present the same issue), the string parameter inside ResourceFinder is not recognized where it is then used at lines 144, 152 and 157. The only difference I can see with the similar resourceName parameter inside ResourceCreator is the fact that the string one is also nested inside Resource when it is accessed.

[ix0rai]

i've encountered this bug before, it's a fairly consistent issue with all anonymous classes i believe

[supersaiyansubtlety]

I looked into this a bit; it's because the param is actually a synthetic field of the anonymous class.

One way to fix it would be to create a proposer that finds these fields and names them after their corresponding params.
It would need to be an internal-only proposer that is allowed to name otherwise un-namable entries, the same kind I suggested in #314.

Enum constants could use the same kind of proposer to get their names (as they already do) and not be namable (because having a different name can cause issues).

Some considerations for making it user friendly+intuitive (these may be cumbersome to implement):

• the record getter and anonymous field proposers could:
  • allow renaming of the component/param when trying to rename the getter/field
  • give the getter/field the same highlighting as the component/param
• enum constants should not have any highlighting (because they're not renamable)