Pin Table Constraint Generation#136
Merged
coolbreeze413 merged 11 commits intodevelopfrom Feb 23, 2026
Merged
Conversation
navidjafarof
commented
Feb 5, 2026
navidjafarof
commented
saaramahmoudi
left a comment
saaramahmoudi
left a comment
There was a problem hiding this comment.
LGTM, just a small comment issue.
src/Compiler/CompilerOpenFPGA_ql.cpp
Outdated
|
|
||
| auto [pinTableFile, error] = findCurrentDevicePinTableCsv(); | ||
| if (pinTableFile.empty()) | ||
| // no pin table csv available, we cannot proceed with the pcf flow! |
There was a problem hiding this comment.
change the comment to match the message error. I think it is old
added 2 commits
February 11, 2026 11:41
…nto nj_pin_table_constraints
coolbreeze413
force-pushed
the
develop
branch
2 times, most recently
from
6fc0bff to
6fcbc60
Compare
…_RESOLVED Nj pin table constraints resolved
…_RESOLVED Nj pin table constraints resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.