Skip to content

Conversation

@phatblat
Copy link
Member

@phatblat phatblat commented May 3, 2020

Are we ready for this yet? Looks like v9 work has started in master and this might be a good time to drop the deprecated Matcher.

Tests still need some work; they compile but I still need to track down crashes.

The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:

  • What behavior was changed?
  • What code was refactored / updated to support this change?
  • What issues are related to this PR? Or why was this change introduced?

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests? Mostly deleting/simplifying tests.
  • Does this have documentation? Docs need to be updated
  • Does this break the public API (Requires major version bump)? Yes 💥
  • Is this a new feature (Requires minor version bump)? Yes 💥

@phatblat phatblat requested review from ikesyo, jeffh and wongzigii May 3, 2020 22:12
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider the deprecation roadmap in the README: https://github.com/Quick/Nimble/blob/master/README.md#deprecation-roadmap

  • We need to do the following before removing the APIs
    • Introduce warnings on migration-path features (.predicate, Predicate-constructors with similar arguments to old API).

  • The README change in #689 needs to be reverted

@ikesyo
Copy link
Member

ikesyo commented May 7, 2020

Submitted #746 for migration-path features deprecation.

@ikesyo
Copy link
Member

ikesyo commented May 14, 2020

Superseded by #746.

@ikesyo ikesyo closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants