[WIP] Swift 3.0 Compatibility #277

norio-nomura · 2016-04-01T15:49:44Z

Uses wrapper that converting from Swift 3.0 API to Swift 2.2 API.
Includes [Do Not Merge] Compatibility updates for the latest swift-corelibs-xctest #261
Uses swift-DEVELOPMENT-SNAPSHOT-2016-03-24-a
Passes swift test on OS X and Linux
Update test script for Linux

norio-nomura · 2016-04-01T15:56:31Z

It seems updating test script for Linux is not needed.

briancroom · 2016-04-01T21:02:37Z

Wow, this looks really great @norio-nomura! I'm especially impressed that you were able to achieve such good 2.2-3.0 compatibility. Could you rebase this when you get a chance?

norio-nomura · 2016-04-01T23:23:08Z

Rebased.

norio-nomura · 2016-04-02T00:17:06Z

Sources/Nimble/Swift3to22.swift

+        }
+    }
+
+    public protocol Sequence: SequenceType {


For supporting uses associatedtype constraints on some functions, Sequence is defined as protocol inheriting SequenceType.
That would require some SequenceType types defined on consumer to conform as:

#if !swift(>=3) extension MyCustomSequence: Nimble.Sequence {} #endif

briancroom · 2016-04-22T01:38:46Z

Hi @norio-nomura, I'm sorry that there's been so little activity around here for so long.

I'm inclined to say that we're best off introducing a swift3 branch for this for now, since the development snapshots are such a fast-moving target at this point and I feel like there's going to be a good bit of churn needed here to keep up. I would tentatively suggest that we could put this on master and do lightweight maintenance of a swift2.2 branch around WWDC-time, when official Swift 3 beta releases will presumably start to be pushed out.

Thoughts @norio-nomura @Quick/contributors?

norio-nomura · 2016-04-22T03:31:34Z

This PR has already been incompatible with swift-DEVELOPMENT-SNAPSHOT-2016-04-12 because of SE-0046 Establish consistent label behavior across all parameters including first labels.
Almost of functions and methods need to be enclosed with #if swift(>=3) for supporting both of swift 2.2 and 3. e.g. https://github.com/antitypical/Result/pull/149/files

norio-nomura · 2016-04-22T03:46:56Z

I can't say which is better whether supporting swift-2.2 and 3 simultaneously or branching them.

modocache · 2016-04-22T15:52:14Z

I'd like to reiterate my thought that XCTest should export both APIs until Swift 3 is officially released: SR-1215. We're doing very little to make things smooth for early adopters of corelibs-xctest, I think we could do better in that respect.

briancroom · 2016-04-29T12:17:13Z

In light of the comments on this PR, this discussion, and the evidence of the complexity of supporting 2.2 and 3 simultaneously as linked to above, I'm pretty convinced at this point that branching is required here. Additionally, I feel that the swift3 branch will need to track the development snapshots pretty closely for the next while, as breaking changes continue to roll in. Given all that, I don't think there is much value in keeping the Swift3to22.swift shim in this PR.

@norio-nomura how would you feel about updating this to work with swift-DEVELOPMENT-SNAPSHOT-2016-04-25? I think we can use this as a start of a swift3 branch at that point.

modocache · 2016-04-29T13:55:01Z

Makes sense to me! Theoretically it's possible to have CI build the Swift 3 branch by compiling Swift from source, then passing SWIFT_EXEC to xcodebuild. That seems like overkill, though--should we just go without CI for Swift 3?

norio-nomura · 2016-04-29T14:30:15Z

I'd happy to update nn-swift-3-compatibility to work with swift-DEVELOPMENT-SNAPSHOT-2016-04-25 and drop supporting swift-2.2. I hope I would do that before next snapshot coming.

briancroom · 2016-04-29T17:52:42Z

Hmm, I wonder how feasible it would be to download and install a toolchain package until Travis starts getting Xcode betas that include a Swift 3 toolchain? Even if we decide not to do that, the Linux CI should still Just Work here, as it is already downloading and installing the specified dev snapshot.

ashfurrow · 2016-04-29T18:04:51Z

If Travis is difficult with OS X builds, I think removing them and keeping Linux for now would be a reasonable compromise.

norio-nomura · 2016-04-29T21:16:41Z

We can use Swift 3 with Xcode 7.3 on Travis-CI as following: https://github.com/norio-nomura/SWXMLHash/blob/nn-swift22-and-swift3-compatibility/.travis.yml#L11-L18

briancroom · 2016-04-29T22:43:48Z

That looks worth trying to me!

norio-nomura · 2016-05-06T16:08:58Z

Rebased and updated to swift-DEVELOPMENT-SNAPSHOT-2016-05-03-a.

Removed Swift 2.2 support. Swift3to22.swift remains for linux support.
podspec fails since swift-DEVELOPMENT-SNAPSHOT-2016-04-12-a
BeCloseToTest fails on linux since swift-DEVELOPMENT-SNAPSHOT-2016-05-03-a

Test cases will need to be `final` for now due to the `Self` reference on the new `allTests` type. Once codegen is available for `allTests` we can get rid of the `final` and the `XCTestCaseProvider` protocol altogether.

Most changes are affected by: [SE-0005](https://github.com/apple/swift-evolution/blob/master/proposals/0005-objective-c-name-translation.md) [SE-0040](https://github.com/apple/swift-evolution/blob/master/proposals/0040-attributecolons.md) [SE-0046](https://github.com/apple/swift-evolution/blob/master/proposals/0046-first-label.md)

… exist

Support Xcode 8 beta 6 and Preview 6

raphaelcruzeiro · 2016-08-23T10:27:54Z

Did you have success using this branch of Nimble to tests actual projects? I'm trying to convert my tests to use this version of Nimble with Swift 3 and I have errors everywhere I use beCloseTo. Namely, Generic parameter 'T' could not be inferred and Ambiguous reference to member 'beCloseTo(_:within:)'. My guess is that Nimble is not working well with CGFloat.

ikesyo · 2016-08-23T10:57:57Z

ReactiveCocoa did: ReactiveCocoa/ReactiveCocoa#3145

norio-nomura · 2016-08-23T11:01:26Z

@raphaelcruzeiro CGFloat was implicitly converted to NSNumber on Swift 2.2.
SE-0072 removes those conversions.
Casting your CGFloat to NSNumber will help you.
Of course PR will be welcomed. 😉

norio-nomura · 2016-08-23T11:27:12Z

Maybe making CGFloat conforming to NMBDoubleConvertible will be better resolution.

raphaelcruzeiro · 2016-08-23T11:28:32Z

@norio-nomura Agreed. I'm gonna start working on that then ;)

… its own method.

CGFloat now conforms to NMBDoubleConvertible

norio-nomura · 2016-08-23T14:19:14Z

Now CGFloat conforms to NMBDoubleConvertible by https://github.com/norio-nomura/Nimble/pull/7
Thank you @raphaelcruzeiro!

pcantrell · 2016-08-23T14:19:58Z

@raphaelcruzeiro: Siesta has been using this fork successfully (and the corresponding Quick fork as well). On the beCloseTo question, I’ve had success using ≈ and ±:

https://github.com/bustoutsolutions/siesta/blob/swift3/Tests/ProgressSpec.swift#L112

I was even able to remove a Double(…) coercion that Swift 2 required.

Thanks, @norio-nomura, for keeping these forks going!

raphaelcruzeiro · 2016-08-23T14:39:54Z

Now that CGFloat conforms to NMBDoubleConvertible it should work fine for all the matchers.

And yeah! Thanks to @norio-nomura for taking the step forward and getting this branch up and working!

`CGFloat` is in Foundation (swift-corelibs-foundation) on Linux.

This should be removed once we get the following: swiftlang/swift-corelibs-foundation#585

Add NMBDoubleConvertible conformance to CGFloat on Linux

# Conflicts: # .travis.yml # test

Resolve conflicts with master

ikesyo · 2016-09-03T07:27:10Z

I'd like to officially manage Swift 3 migration in this repo and I've created swift-3.0 branch. @norio-nomura Could you change the base branch of this PR to that branch? Once that is done, I would merge this and submit a new PR from the branch to master. Then, subsequent PRs for Swift 3 should be targeted on the branch.

norio-nomura · 2016-09-03T08:18:40Z

@ikesyo Thanks! I have changed base branch to swift-3.0. 🙏

ikesyo · 2016-09-03T09:10:35Z

Thank you @norio-nomura and all who contributed to Swift 3 support on this PR! 🎉

[WIP] Swift 3.0 Compatibility

Quick.xcodeproj: Lower iOS deployment target to 7.0

norio-nomura changed the title ~~[WIP] Swift 3 Compatibility~~ Swift 3 Compatibility Apr 1, 2016

norio-nomura changed the title ~~Swift 3 Compatibility~~ Swift 3.0 Compatibility Apr 1, 2016

norio-nomura reviewed Apr 2, 2016
View reviewed changes

norio-nomura mentioned this pull request Apr 2, 2016

[WIP] Swift 3.0 Compatibility Quick/Quick#510

Merged

1 task

norio-nomura changed the title ~~Swift 3.0 Compatibility~~ [WIP] Swift 3.0 Compatibility Apr 29, 2016

ikesyo mentioned this pull request May 3, 2016

Make DynamicProperty generic and automatically support bridgeable value types ReactiveCocoa/ReactiveCocoa#2838

Closed

norio-nomura and others added 9 commits May 9, 2016 23:21

Swift 2.2 and 3.0 compatibility

6a5d3ad

Update to swift-DEVELOPMENT-SNAPSHOT-2016-03-24-a

7e0014b

Update tests to work with the latest swift-corelibs-xctest

8146b55

Test cases will need to be `final` for now due to the `Self` reference on the new `allTests` type. Once codegen is available for `allTests` we can get rid of the `final` and the `XCTestCaseProvider` protocol altogether.

Work around compiler crasher

310a573

Comply to updated XCTest

4c5f081

Remove invalid file reference of Swift3to22.swift from project.pbxproj

47b2b29

swift build --clean produces error when .build directory does not…

f4c6607

… exist

Remove Swift 2.2 support

9fa10f3

Merge pull request #6 from ikesyo/swift3-beta-6

8ed5cb9

Support Xcode 8 beta 6 and Preview 6

raphaelcruzeiro and others added 4 commits August 23, 2016 13:25

CGFloat now conforms to NMBDoubleConvertible

b483a3d

Added CGFloat to the beCloseTo test

ead0e39

Using CGFloat only for the correct targets. Moved the CGFloat test to…

727b06b

… its own method.

Merge pull request #7 from raphaelcruzeiro/rc-CGFloat-Matchers

512fd29

CGFloat now conforms to NMBDoubleConvertible

ikesyo and others added 3 commits August 25, 2016 00:49

Add NMBDoubleConvertible conformance to CGFloat on Linux

c07b141

`CGFloat` is in Foundation (swift-corelibs-foundation) on Linux.

Work around CGFloat(native: ...) description on Linux

595c2a8

This should be removed once we get the following: swiftlang/swift-corelibs-foundation#585

Merge pull request #8 from ikesyo/cgfloat-on-linux

3d82a18

Add NMBDoubleConvertible conformance to CGFloat on Linux

ikesyo mentioned this pull request Aug 30, 2016

Xcode 8 Beta 6 unable to build #325

Closed

ikesyo and others added 2 commits September 3, 2016 00:32

Merge branch 'master' into swift3-merge-master

e629e4e

# Conflicts: # .travis.yml # test

Merge pull request #9 from ikesyo/swift3-merge-master

7952622

Resolve conflicts with master

norio-nomura changed the base branch from master to swift-3.0 September 3, 2016 08:17

ikesyo merged commit 4b539a2 into Quick:swift-3.0 Sep 3, 2016

norio-nomura deleted the nn-swift-3-compatibility branch September 3, 2016 09:11

This was referenced Sep 3, 2016

Swift 3.0 #326

Merged

Move back to Quick/Nimble ReactiveCocoa/ReactiveCocoa#3117

Closed

truizlop mentioned this pull request Oct 21, 2016

Nimble/Nimble-Swift.h file not found #355

Closed

Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019

Merge pull request Quick#277 from norio-nomura/nn-swift-3-compatibility

f7dbf3c

[WIP] Swift 3.0 Compatibility

phatblat pushed a commit to phatblat/Nimble that referenced this pull request May 3, 2020

Merge pull request Quick#277 from Quick/276-ios-7-deployment-target

8bf96f7

Quick.xcodeproj: Lower iOS deployment target to 7.0

Uh oh!

[WIP] Swift 3.0 Compatibility #277

[WIP] Swift 3.0 Compatibility #277

Uh oh!

Conversation

norio-nomura commented Apr 1, 2016 • edited by wongzigii Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

norio-nomura commented Apr 1, 2016

Uh oh!

briancroom commented Apr 1, 2016

Uh oh!

norio-nomura commented Apr 1, 2016

Uh oh!

norio-nomura Apr 2, 2016

Choose a reason for hiding this comment

Uh oh!

briancroom commented Apr 22, 2016

Uh oh!

norio-nomura commented Apr 22, 2016

Uh oh!

norio-nomura commented Apr 22, 2016

Uh oh!

modocache commented Apr 22, 2016

Uh oh!

briancroom commented Apr 29, 2016

Uh oh!

modocache commented Apr 29, 2016

Uh oh!

norio-nomura commented Apr 29, 2016

Uh oh!

briancroom commented Apr 29, 2016

Uh oh!

ashfurrow commented Apr 29, 2016

Uh oh!

norio-nomura commented Apr 29, 2016

Uh oh!

briancroom commented Apr 29, 2016

Uh oh!

norio-nomura commented May 6, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

raphaelcruzeiro commented Aug 23, 2016

Uh oh!

ikesyo commented Aug 23, 2016

Uh oh!

norio-nomura commented Aug 23, 2016

Uh oh!

norio-nomura commented Aug 23, 2016

Uh oh!

raphaelcruzeiro commented Aug 23, 2016

Uh oh!

norio-nomura commented Aug 23, 2016

Uh oh!

pcantrell commented Aug 23, 2016

Uh oh!

raphaelcruzeiro commented Aug 23, 2016

Uh oh!

ikesyo commented Sep 3, 2016

Uh oh!

norio-nomura commented Sep 3, 2016

Uh oh!

ikesyo commented Sep 3, 2016

Uh oh!

Uh oh!

norio-nomura commented Apr 1, 2016 •

edited by wongzigii

Loading

norio-nomura commented May 6, 2016 •

edited

Loading