Skip to content

Swift 2.2 and Xcode 7.3 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2016
Merged

Swift 2.2 and Xcode 7.3 #269

merged 5 commits into from
Mar 24, 2016

Conversation

phatblat
Copy link
Member

General changes to get Nimble to build on Xcode 7.3 without warnings (aside from "Embedded dylibs/frameworks only run on iOS 8 or later")

  • Replace deprecated __FILE__, __LINE__ and __FUNCTION__ with #file, #line and #function, respectively
  • Use new associatedtype keyword
  • Fixed a couple OS X tests that were failing due to @3 not coming through as optional

Supersedes #265

⚠️ These changes require Xcode 7.3 and Swift 2.2 or better.

@briancroom
Copy link
Member

Cool, thanks @phatblat for putting this together! (also thanks @younata for your previous work on this)

Since Xcode 7.3 is out of beta now, I think it would make sense to merge this into master, even though it contains breaking changes. Users who need to stick with earlier Swift versions can continue using the previous releases, and the next release which includes these changes can be 4.0, bumping the version major number. Does that seem right, @jeffh?

@younata
Copy link
Member

younata commented Mar 22, 2016

Thanks for doing this, @briancroom. Wish I had time (this is a lie, I've had time - I've just been busy with other projects) to see this through.

@jlalvarez18
Copy link

What's the status update on this pull request?

@phatblat
Copy link
Member Author

@jlalvarez18 this PR is brand-spankin' new but looks like I didn't break anything, so just a matter of the maintainers reviewing it and then buttoning up a release. 🚢

@modocache
Copy link
Member

Breaking changes be damned, I'm merging this.

2q

@modocache modocache merged commit 758cc9b into Quick:master Mar 24, 2016
@modocache
Copy link
Member

@phatblat Don't suppose I could trouble you to update the Nimble submodule in the Quick build...? 🙏

@phatblat phatblat deleted the pr/swift2.2 branch March 24, 2016 02:37
@phatblat
Copy link
Member Author

On it

@jeffh
Copy link
Member

jeffh commented Mar 24, 2016

@briancroom, yeah it's ok to merge into master since Swift 2.2 is out.

phatblat added a commit to phatblat/Quick that referenced this pull request Mar 24, 2016
Megal pushed a commit to Megal/Nimble that referenced this pull request Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants