Beta 4 compatibility #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in getting Nimble ready for XCode 6 beta 4.
The following things are included in this:
- public accessors added
- removed the bridging header (not supported in Frameworks)
- forward declared NMBExpectation (was getting an error related to it)
I'm still getting an error related to:
Undefined symbols for architecture x86_64:
"_OBJC_CLASS_$_NMBExpectation", referenced from:
objc-class-ref in DSL-B83371164C24FC7F.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
But I'm unfamiliar with what the problem is here.
Per @blindsey's notes, prior change was negating a conditional/nil.
Per @sync's notes on pull request 8.
Remaining items: - Matcher and BasicMatcher not conforming errors - Invalid redeclaration of 'to' (compiler seems to have trouble differentiating between Matcher and BasicMatcher again)
Some notes about the changes here: * made Matcher inherit from BasicMatcher - this way methods that take a Matcher instance can also take a BasicMatcher * failsWithErrorMessage is crashing the running of the tests right now... not sure why yet * Expectation methods that do the actual matching are internal and named toImpl and toNotImpl respectively. I was getting "invalid redeclaration" errors between these methods and the extension methods. * They're internal so that all public access can go through the extension methods. * testArrayEquality is failing to compile right now, specifically calls that take an Array<Int> in as opposed to an array literal (like [1,2,3]). Not sure about that yet.
|
Thanks @tonyd256! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes @drmohundro's work for beta 4 compatibility.