-
-
Notifications
You must be signed in to change notification settings - Fork 7
Fix build and lint configuration issues #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build and lint configuration issues #439
Conversation
- Removed redundant package-lock.json to maintain consistency with Bun. - Updated next.config.mjs to remove 'QCX' from transpilePackages. - Changed lint script to 'eslint .' to resolve next lint CLI errors. - Committed automatic Next.js updates to tsconfig.json and next-env.d.ts as per best practices.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
8033da7
into
fix-oauth-and-credits-integration-2704938752808797816
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing linting from next lint to eslint . can broaden the lint scope and alter ignore behavior; scoping the paths and enabling caching would reduce CI noise and avoid accidentally linting generated artifacts. The jsx switch to react-jsx is generally aligned with modern Next.js defaults and doesn’t raise concerns on its own.
Additional notes (1)
- Maintainability |
package.json:8-14
Switching fromnext linttoeslint .can change which files get linted (and which are excluded) compared to Next’s defaults (e.g., respecting Next-specific conventions, default directories, and.next-related assumptions). This can inadvertently slow CI or lint generated/build artifacts if your.eslintignore/eslintIgnoreisn’t tight.
Given the PR rationale cites a directory resolution error, it’d be safer to keep parity with Next’s intended target set by explicitly scoping the lint paths (and optionally caching).
Summary of changes
What changed
- Updated
package.jsonto run linting viaeslint .instead ofnext lint. - Updated
tsconfig.jsonJSX transform from"jsx": "preserve"to"jsx": "react-jsx"(Next.js modern default).
Note: The PR description mentions additional changes (e.g.,
next.config.mjs,next-env.d.ts, lockfile removal), but only thepackage.jsonandtsconfig.jsondiffs were provided here, so this review is limited to those files.
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||||||
User description
I have resolved several issues that were causing errors during build and development:
package-lock.jsonsince the project uses Bun, which prevents dependency resolution conflicts.QCX(the project name) fromtranspilePackagesinnext.config.mjsto avoid potential recursion and build issues.lintscript inpackage.jsonfromnext linttoeslint .to fix a directory resolution error.tsconfig.jsonandnext-env.d.ts, aligning with modern Next.js development practices.These changes ensure that
bun run buildandbun run devexecute correctly without errors.PR created automatically by Jules for task 2000855008824799080 started by @ngoiyaeric
PR Type
Bug fix
Description
Removed 'QCX' from transpilePackages to prevent build recursion issues
Changed lint script from 'next lint' to 'eslint .' for CLI compatibility
Updated TypeScript configuration to use 'react-jsx' for Next.js alignment
Added Next.js auto-generated route types reference to next-env.d.ts
Diagram Walkthrough
File Walkthrough
next.config.mjs
Remove QCX from transpile packagesnext.config.mjs
transpilePackagesarray, keeping only 'mapbox_mcp'package.json
Update lint script to use eslint directlypackage.json
lintscript fromnext linttoeslint .tsconfig.json
Update JSX compiler option for Next.jstsconfig.json
jsxcompiler option from 'preserve' to 'react-jsx'next-env.d.ts
Add Next.js route types referencenext-env.d.ts