-
-
Notifications
You must be signed in to change notification settings - Fork 105
Replace _doc submodule with redirects to rtd site #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7226b13 to
4953d5d
Compare
|
testDeploy |
5980236 to
3d1861f
Compare
|
PipelineRefresh |
|
testDeploy |
c189169 to
6611e84
Compare
|
testDeploy |
541e636 to
74c25a1
Compare
|
testDeploy |
|
testDeploy |
tokideveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this PR. I tried to be as thorough as possible. However, sometimes I could not decide whether something is right or wrong.
| script: | ||
| - git clone https://gitlab.com/${CI_PROJECT_PATH%%/*}/qubesos.github.io ~/qubesos.github.io -b test | ||
| - ~/qubesos.github.io/_utils/gitlabci.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say whether this is right or wrong. I'm not an expert here. To be reviewed by someone else.
| url: https://doc.qubes-os.org/en/latest/index.html#introduction | ||
| - title: Choosing hardware | ||
| url: /doc/#choosing-your-hardware | ||
| url: https://doc.qubes-os.org/en/latest/index.html#choosing-your-hardware | ||
| - title: Installing and upgrading | ||
| url: /doc/#downloading-installing-and-upgrading-qubes | ||
| url: https://doc.qubes-os.org/en/latest/index.html#downloading-installing-and-upgrading-qubes | ||
| - title: How-to guides | ||
| url: /doc/#how-to-guides | ||
| url: https://doc.qubes-os.org/en/latest/index.html#how-to-guides | ||
| - title: Templates | ||
| url: /doc/#templates | ||
| url: https://doc.qubes-os.org/en/latest/index.html#templates | ||
| - title: Troubleshooting | ||
| url: /doc/#troubleshooting | ||
| url: https://doc.qubes-os.org/en/latest/index.html#troubleshooting | ||
| - title: Security in Qubes | ||
| url: /doc/#security-in-qubes | ||
| url: https://doc.qubes-os.org/en/latest/index.html#security-in-qubes | ||
| - title: Project security | ||
| url: /doc/#project-security | ||
| url: https://doc.qubes-os.org/en/latest/index.html#project-security | ||
| - title: Developer docs | ||
| url: /doc/#developer-documentation | ||
| url: https://doc.qubes-os.org/en/latest/index.html#developer-documentation | ||
| - title: External docs | ||
| url: /doc/#external-documentation | ||
| url: https://doc.qubes-os.org/en/latest/index.html#external-documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, whether modifying these links is necessary. There is a redirect for /doc/ in this PR. Is it to get the fragments/anchors working? I didn't manage it to generate the website on this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately it is necessary. The /doc/ redirect discards the section (the part after #), so it would point at the top of index, not specific place. I don't think it's technically possible to do a redirect that preserves the section anchor.
Applies to all other places like this.
| - column: URL | ||
| links: | ||
| - url: /downloads/mirrors/#instructions-for-mirror-operators | ||
| - url: https://doc.qubes-os.org/en/latest/user/downloading-installing-upgrading/download-mirrors.html#instructions-for-mirror-operators |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
| text: Motherboards | ||
| id: 3 | ||
| - url: /doc/how-to-use-the-hcl/#generating-and-submitting-new-reports | ||
| - url: https://doc.qubes-os.org/en/latest/user/hardware/how-to-use-the-hcl.html#generating-and-submitting-new-reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
| text: What is the hardware compatibility list (HCL)? | ||
| id: 1 | ||
| - url: /doc/how-to-use-the-hcl/#generating-and-submitting-new-reports | ||
| - url: https://doc.qubes-os.org/en/latest/user/hardware/how-to-use-the-hcl.html#generating-and-submitting-new-reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
| {% endif %} | ||
| <!-- Doc link --> | ||
| {% assign doc_link = lang | append: "/doc/" %} | ||
| {% assign doc_link = "https://doc.qubes-os.org/" | append: page.lang | append: "/latest/index.html" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since page.lang could be nil, I suggest the following lines instead of this line 72:
{% if page.lang == nil %}
{% assign doclang = "en" %}
{% else %}
{% assign doclang = page.lang %}
{% endif %}
{% assign doc_link = "https://doc.qubes-os.org/" | append: doclang | append: "/latest/index.html" %}
| #temp fixup | ||
| git remote set-url origin $(git remote get-url origin | sed -e s/gitlab/github/) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say whether this is right or wrong. I'm not an expert here. To be reviewed by someone else.
|
|
||
| ### Image linking | ||
|
|
||
| See [how to add images](https://doc.qubes-os.org/en/latest/developer/general/how-to-edit-the-documentation.html#how-to-add-images) for the required syntax. This will make the image a hyperlink to the image file, allowing the reader to click on the image in order to view the full image by itself. This is important. Following best practices, our website has a responsive design, which allows the website to render appropriately across all screen sizes. When viewing this page on a smaller screen, such as on a mobile device, the image will automatically shrink down to fit the screen. If visitors cannot click on the image to view it in full size, then, depending on their device, they may have no way see the details in the image clearly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link redirects to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/
missing the anchor/fragment #how-to-add-images.
In order to fix it, I suggest to link to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/#how-to-add-images
directly or using magic:
/doc/how-to-edit-the-documentation/#how-to-add-images
However, I did not test my suggestion.
|
|
||
| ### Core vs. external documentation | ||
|
|
||
| Core documentation resides in the [Qubes OS Project's official repositories](https://github.com/QubesOS/), mainly in [qubes-doc](https://github.com/QubesOS/qubes-doc). External documentation can be anywhere else (such as forums, community websites, and blogs), but there is an especially large collection in the [Qubes Forum](https://forum.qubes-os.org/docs). External documentation should not be submitted to [qubes-doc](https://github.com/QubesOS/qubes-doc). If you've written a piece of documentation that is not appropriate for [qubes-doc](https://github.com/QubesOS/qubes-doc), we encourage you to submit it to the [Qubes Forum](https://forum.qubes-os.org/docs) instead. However, *linking* to external documentation from [qubes-doc](https://github.com/QubesOS/qubes-doc) is perfectly fine. Indeed, the maintainers of the [Qubes Forum](https://forum.qubes-os.org/) should regularly submit PRs against the documentation index (see [How to edit the documentation index](https://doc.qubes-os.org/en/latest/developer/general/how-to-edit-the-documentation.html#how-to-edit-the-documentation-index)) to add and update Qubes Forum links in the ["External documentation"](https://qubes-doc-rst.readthedocs.io/en/latest/index.html#external-documentation) section of the documentation table of contents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here:
https://doc.qubes-os.org/en/latest/developer/general/how-to-edit-the-documentation.html#how-to-edit-the-documentation-index
redirects to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/
missing #how-to-edit-the-documentation-index.
Either link to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/#how-to-edit-the-documentation-index
directly or use magic via
/doc/how-to-edit-the-documentation/#how-to-edit-the-documentation-index
Not tested.
|
|
||
| The main difference between **core** (or **official**) and **external** (or **community** or **unofficial**) documentation is whether it documents software that is officially written and maintained by the Qubes OS Project. The purpose of this distinction is to keep the core docs maintainable and high-quality by limiting them to the software output by the Qubes OS Project. In other words, we take responsibility for documenting all of the software we put out into the world, but it doesn't make sense for us to take on the responsibility of documenting or maintaining documentation for anything else. For example, Qubes OS may use a popular Linux distribution for an official [TemplateVM](/doc/templates/). However, it would not make sense for a comparatively small project like ours, with modest funding and a lean workforce, to attempt to document software belonging to a large, richly-funded project with an army of paid and volunteer contributors, especially when they probably already have documentation of their own. This is particularly true when it comes to Linux in general. Although many users who are new to Qubes are also new to Linux, it makes absolutely no sense for our comparatively tiny project to try to document Linux in general when there is already a plethora of documentation out there. | ||
|
|
||
| Many contributors do not realize that there is a significant amount of work involved in *maintaining* documentation after it has been written. They may wish to write documentation and submit it to the core docs, but they see only their own writing process and fail to consider that it will have to be kept up-to-date and consistent with the rest of the docs for years afterward. Submissions to the core docs also have to [undergo a review process](https://doc.qubes-os.org/en/latest/developer/general/how-to-edit-the-documentation.html#security) to ensure accuracy before being merged, which takes up valuable time from the team. We aim to maintain high quality standards for the core docs (style and mechanics, formatting), which also takes up a lot of time. If the documentation involves anything external to the Qubes OS Project (such as a website, platform, program, protocol, framework, practice, or even a reference to a version number), the documentation is likely to become outdated when that external thing changes. It's also important to periodically review and update this documentation, especially when a new Qubes release comes out. Periodically, there may be technical or policy changes that affect all the core documentation. The more documentation there is relative to maintainers, the harder all of this will be. Since there are many more people who are willing to write documentation than to maintain it, these individually small incremental additions amount to a significant maintenance burden for the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here:
https://doc.qubes-os.org/en/latest/developer/general/how-to-edit-the-documentation.html#security
redirects to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/
Link to
https://www.qubes-os.org/doc/how-to-edit-the-documentation/#security
directly or use magic
/doc/how-to-edit-the-documentation/#security
Not tested.
pages/home.html
Outdated
| <div class="white-box more-bottom"> | ||
| <div class="row"> | ||
| <p>Have questions or need a hand? As a free and open-source project, our valued community of users and contributors from around the world are in the best position to help. Before diving in, we encourage you to read about <a href="/support/#staying-safe">staying safe</a>, our <a href="/support/#discussion-guidelines">discussion guidelines</a>, and our <a href="/code-of-conduct/">code of conduct</a> to help keep things positive and on-track. We welcome newcomers and returning users wanting to discuss Qubes and <a href="/doc/contributing/">seeking to contribute</a>. | ||
| <p>Have questions or need a hand? As a free and open-source project, our valued community of users and contributors from around the world are in the best position to help. Before diving in, we encourage you to read about <a href="https://doc.qubes-os.org/en/latest/introduction/support.html#staying-safe">staying safe</a>, our <a href="https://qubes-doc-rst.readthedocs.io/en/latest/introduction/support.html#discussion-guidelines">discussion guidelines</a>, and our <a href="/code-of-conduct/">code of conduct</a> to help keep things positive and on-track. We welcome newcomers and returning users wanting to discuss Qubes and <a href="/doc/contributing/">seeking to contribute</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,12 @@ | |||
| # Contributing to `qubes-doc` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content will be updated later as well as contributing.md in the root dir
| @@ -0,0 +1,11 @@ | |||
| # Qubes OS Documentation | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content will be updated later as well as README.md in root dir
Redirects break section anchors, so put target links directly there.
Redirects break section anchors, so put target links directly there.
358b4c2 to
be15cb7
Compare
Is is not a submodule anymore
8cb315b to
22d4063
Compare
|
testDeploy |
Counterpart to QubesOS/qubes-doc#1479
This currently redirects to the https://doc.qubes-os.org/en/latest/.