-
-
Notifications
You must be signed in to change notification settings - Fork 104
Translation prepare #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation prepare #153
Conversation
|
PipelineRetry |
|
It looks like some of the new code inconsistently uses spaces and tabs for indentation. Since the existing codebase uses all spaces, no tabs should be introduced. |
|
I'm seeing some small bugs:
I don't have time to look through every page of the website, of course, but these are the ones I've noticed so far. I'm also confused about the restructuring. For example, this large file is introduced: https://github.com/QubesOS/qubesos.github.io/blob/9c345c7faf97089415f612bc5e7a7198d4c8b3fb/_data/index.yml But we still have |
I have not changed qubes-doc repo here at all, but I think the doc.md is not used here anymore. The matching PR for qubes-doc (marmarek/qubes-doc#3) removes the doc.md file. TBH, I'd prefer for this indeed be auto-generated, which I think your release-specific split does.
Same for "testing". I've noticed it too. Technically it's trivial to fix, but it will make translation harder, because it will split that sentence into two parts (one for link and one without). IMO linking from the whole sentence is a good compromise. |
|
testdeploy |
That would be fine too, as long as we're not trying to manually keep two or more files in sync.
Ok, that's fine then. |
HTML is hard for translators to handle (to not break markup tags).
Where easily possible html files to markdown. Otherwise, move
translatable strings to separate yaml files (in _data dir), then
use layouts and includes to combine them into original html files. In
many cases it clarifies separation between data na layout, which is good
even without the translation context.
This commit adds also language switcher (useless at this stage) and few
tags to frontmatter ('lang', 'ref') that will be used in subsequent
commits.
And additionally, the files that are changed substantially, have
whitespaces fixed.
And fix header to really work with langmenu disabled
- fix 'testing' text - restore <hr> between releases
Keep it compatible with unchanged qubes-doc repo for now.
9c345c7 to
5c57f7b
Compare
|
testdeploy |
|
@andrewdavidwong I've fixed the issues per the above discussion. |
This is the massive refactor of the main website repository done by @maiska (marmarek#5) but with clean git history. Plus a few fixups. The actual translation tools are not added here yet and the language switcher menu is disabled.
There should be no visual change in the output - I've checked this on a few pages of different types and it seems to be ok.
Merging this now would greatly ease the work on finishing actual translations integration, as we can avoid frequent merge/rebase and conflict resolution.
Thanks @maiska for this work!