Do not connect recording stream unless recording is enabled

[marmarek]

The problem you're addressing (if any)

Currently recording stream is always connected and then depending on recording being allowed it is muted. This results in a confusing long list of recording applications in the volume control, but also uses some resources on the pulseaudio/pipewire server side. This confusion results also in the "recording" icon being always shown in the pulseaudio panel applet in xfce.

The solution you'd like

Connect recording stream only when user allows recording for a VM. Or even only when VM actually records?

The value to a user and who that user might be

Clearer info when/what VM has access to the microphone.

Completion criteria checklist

• separate rec_stdio_event registration from rec_stream (even if recording is not enabled, the return channel of the recording vchan is used for sending commands, and that must work)
• do not connect recording stream initially, but only after recording gets enabled (or even only after VM sends request for recording)
• handle multiple connecting/disconnecting of the stream
• test if xfce recording icon doesn't show up all the time anymore

[qubesos-bot]

Automated announcement from builder-github

The package gui-daemon has been pushed to the r4.3 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update