Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize memory hotplug to add VM memory by qmemman #7956

Closed
marmarek opened this issue Dec 26, 2022 · 2 comments
Closed

Utilize memory hotplug to add VM memory by qmemman #7956

marmarek opened this issue Dec 26, 2022 · 2 comments
Labels
C: core C: kernel P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.2-host-stable release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Milestone
Release 4.2

Comments

@marmarek
Copy link
Member

(...)

Which brings an idea that perhaps we should change how we start VMs:

  • alternative to consider: start with maxmem==memory (400M) and use memory hotplug when more memory is needed

This would require changes to libvirt config (easy) and qmemman (possibly less easy). The current approach is used because memory hotplug used to be unstable, but I think that isn't the case anymore for a long time already.

Originally posted by @marmarek in #7023 (comment)
marmarek added a commit to marmarek/qubes-linux-kernel that referenced this issue Dec 26, 2022
@marmarek
Advertise memory hotplug support
5482f86 
qmemman will rely on it soon (if available).

QubesOS/qubes-issues#7956
@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Dec 26, 2022
@marmarek marmarek added this to the Release 4.2 milestone Dec 26, 2022
@marmarek marmarek added the release notes This issue should be mentioned in the release notes. label Dec 26, 2022
marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Dec 26, 2022
@marmarek
doc: document memory-hotplug feature
4cf6a87 
QubesOS/qubes-issues#7956
@marmarek marmarek mentioned this issue Dec 26, 2022
Merged
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 26, 2022
@marmarek
qmemman: use memory hotplug in qmemman
66e715a 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
This was referenced Dec 26, 2022
Merged
Closed
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 27, 2022
@marmarek
qmemman: use memory hotplug in qmemman
ba040a0 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 27, 2022
@marmarek
qmemman: use memory hotplug in qmemman
c769961 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 27, 2022
@marmarek
qmemman: use memory hotplug in qmemman
f3f009b 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
This was referenced Dec 27, 2022
Closed
Closed
marmarek added a commit to QubesOS/qubes-linux-kernel that referenced this issue Dec 27, 2022
@marmarek
Advertise memory hotplug support
f7c1bd0 
qmemman will rely on it soon (if available).

QubesOS/qubes-issues#7956

(cherry picked from commit 5482f86)
This was referenced Dec 27, 2022
Closed
Closed
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 28, 2022
@marmarek
qmemman: use memory hotplug in qmemman
fd7b525 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 28, 2022
@marmarek
qmemman: use memory hotplug in qmemman
32d44cc 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. Qmemman almost had
all the needed parts - especially mem_set function already adjusts
maxmem too. The missing part was letting it know actual maxmem - do that
via xenstore (as qmemman uses xenstore heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
This was referenced Jan 9, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 20, 2023
Closed
Closed
marmarek added a commit to marmarek/qubes-core-libvirt that referenced this issue Aug 6, 2023
@marmarek
libxl: setup shadow memory according to max hotplug memory
62c5c57 
The '<maxMemory>' domain XML element is about maximum memory to be hot
plugged. Make libxl support this for calculating shadow memory amount,
which is used by Xen for internal accounting of domain memory (among
other things). If shadow memory is calculated based on initial memory,
then the domain can hotplug up to about twice that memory, but not more
(it silently doesn't get more).

QubesOS/qubes-issues#7956
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Aug 7, 2023
@marmarek
qmemman: use memory hotplug in qmemman
7d50f2e 
If VM supports memory hotplug, start it with maxmem=memory and then use
memory hotplug to (potentially) increase its memory. The hotplug maxmem
needs to be communicated to libvirt->libxl via <maxMemory> element, so
Xen will reserve appropriate amount of memory for internal accounting
(this currently is a patch in qubes package, not available upstream
yet). Qmemman almost had all the needed parts - especially mem_set
function already adjusts maxmem too. The missing part was letting it
know actual maxmem - do that via xenstore (as qmemman uses xenstore
heavily already).

The use of memory hotplug can be enabled (or disabled) explicitly via
'memory-hotplug' feature, or detected based on
'memory-hotplug-supported' file in dom0-provided kernel dir, or
'supported-feature.memory-hotplug' for VM-provided kernel.

Fixes QubesOS/qubes-issues#7956
@andrewdavidwong andrewdavidwong removed this from the Release 4.2 milestone Aug 13, 2023
@qubesos-bot qubesos-bot mentioned this issue Aug 17, 2023
Closed
marmarek added a commit to QubesOS/qubes-linux-kernel that referenced this issue Oct 10, 2023
@marmarek
Mark kernel as supporting memory hotplug
981f95d 
QubesOS/qubes-issues#7956
This was referenced Oct 10, 2023
Closed
Closed
Closed
@qubesos-bot qubesos-bot mentioned this issue Oct 12, 2023
Closed
@andrewdavidwong andrewdavidwong added this to the Release 4.2 milestone Oct 12, 2023
@grnklod grnklod mentioned this issue Oct 13, 2023
Closed
marmarek added a commit to QubesOS/qubes-linux-kernel that referenced this issue Oct 14, 2023
@marmarek
Mark kernel as supporting memory hotplug
417330f 
QubesOS/qubes-issues#7956

(cherry picked from commit 981f95d)
This was referenced Oct 14, 2023
Closed
Closed
@qubesos-bot qubesos-bot mentioned this issue Oct 22, 2023
Closed
@qubesos-bot qubesos-bot mentioned this issue Apr 17, 2024
Closed
marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Apr 20, 2024
@marmarek
Report when in-vm kernel supports memory hotplug
07a5c7b 
QubesOS/qubes-issues#7956
@marmarek marmarek mentioned this issue Apr 20, 2024
Merged
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Apr 20, 2024
@marmarek
Improve checking for memory hotplug support
8121cb0 
1. Fix handling HVM to match the intention described in the comment.
2. Fix distinguishing dom0-provided and vm-provided kernels - the actual
   "kernel" property value depends on the virt_mode

QubesOS/qubes-issues#7956
@marmarek marmarek mentioned this issue Apr 20, 2024
Merged
marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Apr 20, 2024
@marmarek
Report when in-vm kernel supports memory hotplug
b25ae5e 
QubesOS/qubes-issues#7956
marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Apr 22, 2024
@marmarek
Report when in-vm kernel supports memory hotplug
cc4789b 
QubesOS/qubes-issues#7956
This was referenced Apr 22, 2024
Closed
Closed
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Apr 24, 2024
@marmarek
Improve checking for memory hotplug support
3445e22 
1. Fix handling HVM to match the intention described in the comment.
2. Fix distinguishing dom0-provided and vm-provided kernels - the actual
   "kernel" property value depends on the virt_mode

QubesOS/qubes-issues#7956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core C: kernel P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.2-host-stable release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Milestone
Release 4.2
Development

No branches or pull requests
4 participants
@marmarek @DemiMarie @andrewdavidwong @qubesos-bot