Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qvm-open-in-dvm tries to start the disposable twice #7031

Closed
marmarek opened this issue Nov 2, 2021 · 9 comments · Fixed by QubesOS/qubes-core-qrexec#85
Closed

qvm-open-in-dvm tries to start the disposable twice #7031

marmarek opened this issue Nov 2, 2021 · 9 comments · Fixed by QubesOS/qubes-core-qrexec#85
Labels
C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-stable r4.1-dom0-stable r4.1-fc32-stable r4.1-fc33-stable r4.1-fc34-stable r4.1-fc35-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.1

Comments

@marmarek
Copy link
Member

marmarek commented Nov 2, 2021

How to file a helpful issue

Qubes OS release

R4.1

Brief summary

When the disposable qube start fails (for example not enough memory), qvm-open-in-dvm (or rather: qrexec handling the request at dom0 side) tries to start the disposable twice.

This is likely an interaction with qrexec-policy-daemon and a fallback to qrexec-policy-exec.

Steps to reproduce

  1. Have not enough memory
  2. Try to open a file in a disposable qube

Expected behavior

The call fails after trying to start the disposable once

Actual behavior

It tries to start it twice.
@marmarek marmarek added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Nov 2, 2021
@marmarek marmarek added this to the Release 4.1 milestone Nov 2, 2021
@andrewdavidwong andrewdavidwong added the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Nov 3, 2021
@rustybird
Copy link

In case it helps with the diagnosis: Before #7023 ('VM killed with "out of PoD memory" error') was fixed, I noticed the same 2 attempts to start a VM - but here it was in R4.0 when running qubes.StartApp (and IIRC qubes.VMShell too), for any type of VM, initiated by dom0.

marmarek added a commit to marmarek/qubes-core-qrexec that referenced this issue Dec 1, 2021
@marmarek
policy: fix reporting failed target start
a04ffe2 
Report it as proper failed call exception, so that policy-daemon will
report it back properly as refused call. Otherwise qrexec-client will
fallback to a direct qrexec-policy-exec call. This would cause second
(unexpected) start try.

Fixes QubesOS/qubes-issues#7031
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Dec 7, 2021
@marmarek
tests: spurious double DispVM startup
251d8aa 
QubesOS/qubes-issues#7031
This was referenced Dec 13, 2021
Merged
Merged
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-qrexec has been pushed to the r4.1 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Dec 17, 2021
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-qrexec_4.1.16-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-qrexec (including package qubes-core-qrexec-4.1.16-1.fc32) has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-qrexec (including package qubes-core-qrexec-4.1.16-1.fc32) has been pushed to the r4.1 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Dec 18, 2021
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-qrexec has been pushed to the r4.1 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-qrexec_4.1.16-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-qrexec (including package qubes-core-qrexec-4.1.16-1.fc32) has been pushed to the r4.1 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-qrexec (including package qubes-core-qrexec-4.1.16-1.fc32) has been pushed to the r4.1 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Feb 14, 2022
Closed
@qubesos-bot qubesos-bot mentioned this issue Mar 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.1-bullseye-stable r4.1-buster-stable r4.1-centos-stream8-stable r4.1-dom0-stable r4.1-fc32-stable r4.1-fc33-stable r4.1-fc34-stable r4.1-fc35-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.1
Development

Successfully merging a pull request may close this issue.

policy: fix reporting failed target start marmarek/qubes-core-qrexec
4 participants
@marmarek @rustybird @andrewdavidwong @qubesos-bot