Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qvm-shutdown on paused VMs behaves oddly #5987

Closed
3hhh opened this issue Aug 7, 2020 · 4 comments
Closed

qvm-shutdown on paused VMs behaves oddly #5987

3hhh opened this issue Aug 7, 2020 · 4 comments
Labels
C: core eol-4.0 Closed because Qubes 4.0 has reached end-of-life (EOL) P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. ux User experience

Comments

@3hhh
Copy link

3hhh commented Aug 7, 2020

Qubes OS version
4.0

Affected component(s) or functionality
qvm-shutdown

Brief summary
qvm-shutdown hangs for a while and then apparently kills paused VMs.

To Reproduce

qvm-run --dispvm surfing-dvm xterm
qvm-pause disp1234
qvm-shutdown --wait disp1234

Expected behavior
qvm-shutdown performs the shutdown. Possibly even gracefully (i.e. by unpausing the VM first).

Actual behavior
qvm-shutdown hangs for 10s or so. Then it apparently kills the VM.

Recommendation
From my point of view it would be sensible to handle paused VMs as follows:

qvm-shutdown: Unpause and shutdown gracefully as usual.
qvm-kill: Do not unpause, remove it from memory instantly (shouldn't take 10s).

Related, non-duplicate issues
#5967

@3hhh 3hhh added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Aug 7, 2020
3hhh added a commit to 3hhh/qubes-terminal-hotkeys that referenced this issue Aug 7, 2020
@andrewdavidwong andrewdavidwong added C: core needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. ux User experience labels Aug 10, 2020
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Aug 10, 2020
@andrewdavidwong
Copy link
Member

I can imagine that there might be a security concern here. If a VM was paused because it was doing something malicious, then I suppose unpausing it could be dangerous, even if only to shut it down. If that's the reason for the current behavior, perhaps the user should be prompted when attempting to a shut down a paused VM. Also, it may very well be that the user attempting the shutdown forgot that the VM was paused and would be grateful to be reminded.

@3hhh
Copy link
Author

3hhh commented Aug 10, 2020

I can imagine that there might be a security concern here. If a VM was paused because it was doing something malicious, then I suppose unpausing it could be dangerous, even if only to shut it down. If that's the reason for the current behavior, perhaps the user should be prompted when attempting to a shut down a paused VM. Also, it may very well be that the user attempting the shutdown forgot that the VM was paused and would be grateful to be reminded.

That's what qvm-kill is for. Anyway this is not about the GUI in qubes-manager which allows to kill or unpause only anyway.

If a user manages to mistype qvm-shutdown vs qvm-kill I am reluctant to feel sorry. And if he forgot about that malicious paused VM, then apparently it wasn't so bad at all.

@andrewdavidwong
Copy link
Member

That's what qvm-kill is for. Anyway this is not about the GUI in qubes-manager which allows to kill or unpause only anyway.

If a user manages to mistype qvm-shutdown vs qvm-kill I am reluctant to feel sorry.

The user not knowing the difference seems much more likely than a typo.

And if he forgot about that malicious paused VM, then apparently it wasn't so bad at all.

Oh, those were meant to be two separate examples.

@andrewdavidwong andrewdavidwong added the eol-4.0 Closed because Qubes 4.0 has reached end-of-life (EOL) label Aug 5, 2023
@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue is being closed because:

If anyone believes that this issue should be reopened and reassigned to an active milestone, please leave a brief comment.
(For example, if a bug still affects Qubes OS 4.1, then the comment "Affects 4.1" will suffice.)

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2023
@andrewdavidwong andrewdavidwong removed the needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. label Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core eol-4.0 Closed because Qubes 4.0 has reached end-of-life (EOL) P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. ux User experience
Projects
None yet
Development

No branches or pull requests

2 participants