Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qubes-dom0-update improperly quotes parameters #5096

Closed
Rudd-O opened this issue Jun 13, 2019 · 9 comments
Closed

qubes-dom0-update improperly quotes parameters #5096

Rudd-O opened this issue Jun 13, 2019 · 9 comments
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-bullseye-cur-test r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc29-stable r4.0-fc30-stable r4.0-jessie-stable r4.0-stretch-stable r4.1-buster-cur-test r4.1-centos7-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-stretch-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.0 updates

Comments

@Rudd-O
Copy link

Rudd-O commented Jun 13, 2019 •
edited
Loading

Qubes OS version

4.0.1

Affected component(s) or functionality

dom0 installs of packages

Brief summary

sudo qubes-dom0-update -y 'libzstd.so.1()(64bit)' (correct) fails with a shell error
sudo qubes-dom0-update -y "'libzstd.so.1()(64bit)'" (wild guess) fails with a different error

These are legitimate arguments to dnf, for the record.
@Rudd-O Rudd-O added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Jun 13, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Jun 14, 2019
@qubesos-bot qubesos-bot mentioned this issue Aug 11, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.1.3-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.1 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

marmarek pushed a commit to QubesOS/qubes-core-agent-linux that referenced this issue Sep 7, 2019
@m-v-b @marmarek
dom0-updates: Quote arguments
614d281 
This commit makes the qubes-download-dom0-updates.sh script quote its
arguments before using them to avoid expanding wildcards (such as '*')
unintendedly.

Fixes QubesOS/qubes-issues#5096

(cherry picked from commit 8db8d0c)
marmarek pushed a commit to QubesOS/qubes-core-admin-linux that referenced this issue Sep 10, 2019
@m-v-b @marmarek
qubes-dom0-update: Quote arguments
13d6c90 
This commit ensures that all arguments to qubes-download-dom0-updates.sh
are properly quoted. This allows the use of commands such as

  sudo qubes-dom0-update --action=distro-sync '*'

where, prior to this commit, the asterisk would be expanded in the
update virtual machine's home directory, whereas this commit prevents
the undesirable shell expansion of wildcards.

Fixes QubesOS/qubes-issues#5096

(cherry picked from commit 1089a7a)
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Sep 10, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.0.48-1 has been pushed to the r4.0 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.19-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Sep 10, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.1.1-1.fc29 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot mentioned this issue Sep 24, 2019
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.0 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.0.48-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-linux-4.0.19-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. r4.0-bullseye-cur-test r4.0-buster-stable r4.0-centos7-stable r4.0-dom0-stable r4.0-fc29-stable r4.0-fc30-stable r4.0-jessie-stable r4.0-stretch-stable r4.1-buster-cur-test r4.1-centos7-cur-test r4.1-dom0-cur-test r4.1-fc29-cur-test r4.1-fc30-cur-test r4.1-stretch-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.0 updates
Development

No branches or pull requests
3 participants
@Rudd-O @andrewdavidwong @qubesos-bot