-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundancies in the app menu caused by synchronized flatpak apps #5076
Comments
I think the place for such processing is in On the other hand, I think there should be only one instance of given application in the final menu, even if multiple instances are available (VM settings - applications tab). This means it's more important to distinguish applications in that settings window than in the final menu. This allows to use also other fields of desktop file (comment, genericname etc) and perhaps adding them as a tooltip to the application selection dialog (which is a good idea anyway). Please also remember that .desktop files needs to be unique, even if they are in different directories. If you have same named desktop file in different directories, it will be visible as one (AFAIR the one listed later by qubes.GetAppmenus prevails). I think this is ok, as long as it is really the same application - which is the case for system and user installed flatpak. |
@marmarta : do you think that would something you could parse easily? For example, we think about adding |
Sounds fine; I think I'm just going to add to qvm-appmenus an option to list selected fields from the .desktop files, and then show as tooltip the contents of the Comment field. |
For the record: here is specification of the file format, with list of available fields: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys |
Adding the optional --file-field parameter. It changes to output format to '|'-separated one, and outputs not only file name and app name, but also whatever fields from the file the user has requested. Used by GUI VM settings. references QubesOS/qubes-issues#5076
The 'Comment' field will not be displayed as a tooltip in VM settings. Requires QubesOS/qubes-desktop-linux-common#12 references QubesOS/qubes-issues#5076
The 'Comment' field will now be displayed as a tooltip in VM settings. Requires QubesOS/qubes-desktop-linux-common#12 references QubesOS/qubes-issues#5076
Okay, I added it (pull requests pending ofc); I think just adding it to the 'Comment' field and displaying that in Settings is best - I think it's important mostly in the Settings, once the user sets their Apps like they want it doesn't matter where are they from. |
Adding the optional --file-field parameter. It changes to output format to '|'-separated one, and outputs not only file name and app name, but also whatever fields from the file the user has requested. Used by GUI VM settings. references QubesOS/qubes-issues#5076
Adding the optional --file-field parameter. It changes to output format to '|'-separated one, and outputs not only file name and app name, but also whatever fields from the file the user has requested. Used by GUI VM settings. references QubesOS/qubes-issues#5076
Adding the optional --file-field parameter. It changes to output format to '|'-separated one, and outputs not only file name and app name, but also whatever fields from the file the user has requested. Used by GUI VM settings. references QubesOS/qubes-issues#5076
The 'Comment' field will now be displayed as a tooltip in VM settings. Requires QubesOS/qubes-desktop-linux-common#12 references QubesOS/qubes-issues#5076
Adding the optional --file-field parameter. It changes to output format to '|'-separated one, and outputs not only file name and app name, but also whatever fields from the file the user has requested. Used by GUI VM settings. references QubesOS/qubes-issues#5076
@marmarta Thanks for working on this issue. |
One idea would be to source |
@marmarek @fepitre |
Not every line is an assignment, skip lines not containing '='. Also, skip non-main sections (although the current generator accepts only main section anyway). QubesOS/qubes-issues#5076
The problem you're addressing (if any)
I'm currently working on a post install script(such as the dnf hook) that would synchronize the app menu with newly installed flatpak apps and eventually mention the app source "(Flatpak)" in the app name, whenever a Flatpak app is added.
However, having the same app installed twice, either through flatpak only (per-user and system-wide) or with flatpak and from any other source, can cause apps to be redundant in the app menu after synchronization. It would be better to avoid this confusion by specifying the app source.
Describe the solution you'd like
One solution would be to append "(Flatpak)" to the app name in desktop files every time a flatpak app is installed. Eventually, I admit that appending (Flatpak user)/(Flatpak system) is a foolproof solution to distinguish all apps having the same name.
Where is the value to a user, and who might that user be?
Better end-user experience.
Describe alternatives you've considered
Appending « Flatpak sys/user » only if there is the same application from any other source already installed.
However, it’s a solution that would involve a template based app vm to be supervised while being in the TemplateVm, giving to this one the awareness of all newly installed apps and vice versa.
Only this way, the post install script could add/remove “Flatpak” specification to/from the concerned app name. But, as long as this alternative requires an eventual Vm's interaction, almost unacceptable in Qubes OS, i'd rather be against.
The text was updated successfully, but these errors were encountered: