-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<ctrl><shift>P (qvm-pause --all) should also show a notification informing the user of what they have done and how to undo it #4101
Comments
This I think is really good idea you bring up (imho), especially the unlock in the upper right corner idea, and the tour application idea is also pretty neat.
I'd like to add some extra minor details to consider. Consider and communicate whether user using pause to pause long-term is safe and desirable The benefit of that is if you got something that you need to keep running, it'd be nice if the VM environments exposed to the internet or otherwise can be kept safe while away, rather than having to restart all the VM's just to be safe. Consider some extra pause flexibility
Some of these might warrant a new issue if they are pursued though, but for now listing some ideas here. |
I'd like to add that during the transition of 3.2 to 4.0, some "advanced" features were pushed back, away from the GUI, towards the command line. E.g., the UpdateVM setting is no longer available in the Qubes Manager. Although I understand the reasoning (to make it less intimidating to new users), I'd rather see a menu option like "Turn advanced features on", which allows power-users-without-all-the-command-line-kung-fu-skills to be able to at least see and if needed change that setting/those settings. By default, that option should be "off". And, Ctrl-Shift(-Alt)-P, a black belt third dan keystroke, should only be enabled if the "Turn advanced features on" switch is set to "on". |
I must say, this is a really important enhancement. In firefox, opening a private window is done with this exact same set of keys. I used them and thought the computer was crashed. A pop-up message would've saved me the trouble, that's for sure. The Qube Manager should also present something, since the state "light" keeps being green. |
I can't think of a reason why you'd want to manually pause all VMs at once, much less need a keyboard shortcut for it. Rather than implementing some notification, I think this keyboard shortcut should be removed from the default ones. Anyone who wants to pause all VMs can still do it via the command line, they know what they're doing and don't need a notification either. Edit 13: Maybe manual pause-all is used to prevent covert channels from an offline VM? Pause all VMs, start your offline vault, do secret stuff, shutdown vault, resume-all VMs? |
for context of when this behavior was decided: #881
There is definitely sane rationale there, however a person would only know it exists (and would know to use it during a gui DoS) if he was informed prior to any issues via some sort of tour/info/etc method. A notification doesn't solve this extended issue very well. |
Since this hotkey Ctrl-Shift-P conflicts for example with Firefox' incognito mode (and even being a power user myself it took me a while, without usb mouse, to find out what happened), I'd absolutely remove this """""feature""""" altogether. Manual "fix"Go to Start Menu -> System Tools -> Keyboard -> Application Shortcuts |
The notification is implemented in QubesOS/qubes-desktop-linux-manager#29 |
The USB keyboard / sys-usb scenario on the "duplicate" issue appears to be a good reason to re-open and re-examine this issue. |
Yes, and it doesn’t help when you have no functional input method. I have commented further on #4700. I note that the experience I had was exactly what earlier contributors in this issue predicted. With all due respect, I think there has been a loss of perspective here leading to some poor decisions about choice of hotkey and user confirmation. (Breaking USB input is an outright bug). I accept the justification for this feature but it is a very narrow use case which IMO does not justify creating a “landmine” (you don’t know its there until you step on it) for the whole user population. |
Yeah, I'm seriously agreeing with the 'loss of perspective' comment. This is not a feature, this is a malevolent trap. If someone is a power user and gets attacked by a malicious VM, they can switch to console with Alt+F2 and kill VMs they don't like. And if someone is not a power user, they won't remember that shortcut anyway and the good old panic shutdown still works. Power users can add that shortcut if they want to, but it should not be default. Any solution that can lead to system being unresponsible due to cat-on-keyboard is a bad solution. |
First of all Ctrl+Alt+P is too common key combo (for example conflicts with Firefox's "New Private Window"). But even if that wouldn't be true, in the current shape it does more harm than good, because it is not documented (hard to discover when actually needed), and also pause system VMs which in case of sys-usb and USB keyboard is fatal. Lets rethink this first. This reverts commit 9459331. QubesOS/qubes-issues#881 QubesOS/qubes-issues#4101 Fixes QubesOS/qubes-issues#4700
First of all Ctrl+Alt+P is too common key combo (for example conflicts with Firefox's "New Private Window"). But even if that wouldn't be true, in the current shape it does more harm than good, because it is not documented (hard to discover when actually needed), and also pause system VMs which in case of sys-usb and USB keyboard is fatal. Lets rethink this first. This reverts commit 9459331. And adds a script to adjust user configuration. QubesOS/qubes-issues#881 QubesOS/qubes-issues#4101 Fixes QubesOS/qubes-issues#4700
Qubes OS version:
4.0
Affected component(s):
The default hotkey settings
Steps to reproduce the behavior:
Be a new user
who didn't read the documentation enough(is it in any documentation?) and then pressed PExpected behavior:
see "All VMs paused. Press P to unpause" in the top right of my screen
Actual behavior:
Feeling very confused and lost, needing to restart (which takes forever due to the paused VMs), and then after doing so, search online to find a random github issue which hints at what happened when I wanted to open the command palette in my text editor!
General notes:
This could also be solved with having a "tour" application, or for a very quick "fix": have the default background have the default hotkeys written on it!
Related issues:
The text was updated successfully, but these errors were encountered: