Further improvements #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens during testing where I have to reload i3 to reapply the status.
- Console can be called when specifying it as a parameter; - Avoiding GUI skips extraneous calls, if you have a window of a qube, it already has a GUI; - Use qubes-run-terminal instead of duplicating implementations, on dom0, uses upstream program; and - Using service calls rather than shell calls to respect qube XDG overrides and to allow sending the program to the background. Unsure if the XDG override is useful for opening a terminal in the qube, seems only related to app-dispvm feature.
- i3 doesn't load variables, it replaces them in the file they were defined, included files cannot use variables defined outside of their own files, so use of included directories is limited to actions that don't complain when duplicated (binded keys throws an error if duplicated). It is possible with BEGIN and END markers to substitute all those variables or you can substitute individual ones with sed; - Use a faster dmenu desktop loader such as j4-dmenu-desktop, noticeable when you have a lot of qubes and consecutively, a lot of desktop applications; - Use dmenu vertical view with a long list of items, helps when there are many qubes; - Use dmenu insensitive case matching, who remembers that it is "XTerm", with upper case X and T? Also some desktop files capitalize every word while others doesn't, such as "Run Terminal" and "Start qube"; - i3lock screen is too bright, make it darker; - Convert modifier key to use as a variable; - Some configuration was only in one config, therefore users were missing things if they accepted i3-config-wizard, as then it only sources ~/.config/i3/config and not the /etc/i3/config anymore; - Make Zenity float, happens on split-gpg2 popups; - Space key doesn't seem to work well on i3, replaced it with another key.
- eval is needed to not introduce quoting problems; - array avoids multiple grep calls; - log which desktop is being parsed for easier debugging; - introduced locale support to know which application started.
This was referenced Nov 5, 2025
Open
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025120822-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests17 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 20 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:42 performance degradations
Remaining performance tests:134 tests
|
This was referenced Nov 5, 2025
Contributor
|
I believe the last commits have to be duplicated to |
This was referenced Nov 11, 2025
This was referenced Nov 16, 2025
This was referenced Nov 23, 2025
This was referenced Dec 2, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #20