Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0017 patch: Add gfx_passthru option #23

Closed
wants to merge 2 commits into from
Closed

0017 patch: Add gfx_passthru option #23

wants to merge 2 commits into from

Conversation

cytadela8
Copy link

@cytadela8 cytadela8 commented Apr 24, 2020 •
edited
Loading

Required for Intel GPU passthrough.

QubesOS/qubes-issues#2618

@cytadela8
0017 patch: Add gfx_passthru option
5535c27 
Required for Intel GPU passthrough.

Signed-off-by: Artur Puzio <contact@puzio.waw.pl>
@cytadela8 cytadela8 mentioned this pull request Apr 24, 2020
Merged
@marmarek
Copy link
Member

Since the patches this base on are already included in libvirt upstream master, I recommend sending this patch too.

@marmarek
Copy link
Member

You need to also update relevant test - see build log in travis.

@marmarek
Copy link
Member

**policy/qubesos/code-signing ** — Unable to verify (no valid key found)

Please upload public key to a keyserver

@cytadela8 cytadela8 force-pushed the patch-add-gfx-passthru branch 3 times, most recently from a44ee05 to 7cc2a70 Compare April 30, 2020 13:11
@cytadela8
0018 patch: vga.kind none when no device specified
7cc2a70 
When no video device is specified in config we should set both
hvm.nographic to 1 and hvm.vga.kind to NONE.

Without hvm.vga.kind=LIBXL_VGA_INTERFACE_TYPE_NONE both -nographic and
-device 'cirrus-vga' are on qemu cmdline.
@cytadela8
Copy link
Author

Hmm, for me it shows the key is on pool.sks-keyservers.net

gpg --keyserver pool.sks-keyservers.net --search-key contact@puzio.waw.pl
gpg: data source: http://62.210.187.135:11371
(1)     Artur Puzio <contact@puzio.waw.pl>
        Artur Puzio (GitHub commits) <cytadela8@users.noreply.github.com>
          4096 bit RSA key D87762204CFFE72F, utworzono: 2018-08-17

@marmarek
Copy link
Member

marmarek commented Jun 7, 2020

As discussed on the libvirt mailing list, a better approach would be to automatically enable this option at libxl level. Here is the patch:
https://lists.xenproject.org/archives/html/xen-devel/2020-06/msg00471.html

We'll see what libxl maintainers will say (I guess "too late for Xen 4.14"), but I'd go with patching libxl like this instead of patching libvirt anyway. So, I'm closing this for now.
This also makes QubesOS/qubes-core-admin@3e8f5a7 unnecessary (I'll revert it), and similarly setting this qvm-feature is not needed anymore.

@marmarek marmarek closed this Jun 7, 2020
@marmarek marmarek mentioned this pull request Jun 7, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cytadela8 @marmarek