qubes.WaitForSession: refactor by waiting for qrexec-fork-server socket #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 65.48% 65.48%
=======================================
Files 2 2
Lines 394 394
=======================================
Hits 258 258
Misses 136 136Continue to review full report at Codecov.
|
marmarek
requested changes
Nov 2, 2019
qubes-rpc/qubes.WaitForSession
Outdated
| fi | ||
| # the above line is _expected_ to be terminated by a signal, don't treat this as a failure | ||
| exit 0 | ||
| while ! [ -e /var/run/qubes/qrexec-server.user.sock ] |
There was a problem hiding this comment.
You should use the actual username instead of hardcoded user - see the old version how to obtain it.
marmarek
approved these changes
Nov 2, 2019
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/4650#dependencies Failed tests
|
marmarek
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QubesOS/qubes-issues#5662
QubesOS/qubes-issues#833