Update Whonix-Workstation file open and dispvm open tests #705
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 70.53% 70.53%
=======================================
Files 61 61
Lines 13546 13546
=======================================
Hits 9554 9554
Misses 3992 3992
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Whonix-Workstation now presents a qrexec confirmation prompt to the user before opening files in a DispVM or existing Whonix-Workstation VM. Explicitly confirm these actions in the appropriate tests.
ArrayBolt3
force-pushed
the
arraybolt3/whonix-disp-qrexec
branch
from
0e0a1c8 to
c2bd753
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025072115-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests14 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 11 fixed
Unstable testsPerformance TestsPerformance degradation:8 performance degradations
Remaining performance tests:64 tests
|
|
The exception handling is a bit unusual (with returning tuple - looks like golang?), but it works, so lets keep it. For future, you can simply call |
|
Ah, I thought it might be safe to use |
Whonix-Workstation now presents a qrexec confirmation prompt to the user before opening files in a DispVM or existing Whonix-Workstation VM. Explicitly confirm these actions in the appropriate tests.
This is my initial attempt at implementing option 2 from QubesOS/qubes-core-admin-addon-whonix#22 (comment), to get OpenQA's tests to pass. I don't have a system set up to allow me to run rtests on dom0, so I have no clue if this works, we'll need to wait for another OpenQA run to tell us that (or I'll need to overhaul my testing system).